linux-kernel - RE: [PATCH] RDMA/core: fix a NULL-pointer dereference in hw_stat_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CY8PR12MB7195E91917FD5329932FA3FCDCC02@CY8PR12MB7195.namprd12.prod.outlook.com>
Date: Mon, 24 Feb 2025 15:16:46 +0000
From: Parav Pandit <parav@...lanox.com>
To: Jason Gunthorpe <jgg@...dia.com>
CC: Roman Gushchin <roman.gushchin@...ux.dev>, Leon Romanovsky
	<leon@...nel.org>, Maher Sanalla <msanalla@...dia.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] RDMA/core: fix a NULL-pointer dereference in
 hw_stat_device_show()



> From: Jason Gunthorpe <jgg@...dia.com>
> Sent: Monday, February 24, 2025 8:41 PM
> 
> On Sat, Feb 22, 2025 at 06:34:21PM +0000, Parav Pandit wrote:
> > ib_setup_device_attrs() should be merged to ib_setup_port_attrs() by
> > renaming ib_setup_port_attrs() to be generic.  To utilize the group
> > initialization ib_setup_port_attrs() needs to move up before
> > device_add().
> 
> It needs more than that, somehow you have to maintain two groups list or
> somehow remove the coredev->dev.groups assignment..
> 
I was thinking that if both device and port attr setup is done in same function, there is knowledge of is_full_dev that can be used for device level hw_stats setup. (similar to how its done at port level).

> Jason