linux-kernel - Re: [PATCH v4 5/5] i3c: master: svc: Fix npcm845 DAA process corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7yfwXh+ZmfbhWVj@lizhi-Precision-Tower-5810>
Date: Mon, 24 Feb 2025 11:35:13 -0500
From: Frank Li <Frank.li@....com>
To: Stanley Chu <stanley.chuys@...il.com>
Cc: miquel.raynal@...tlin.com, alexandre.belloni@...tlin.com,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, tomer.maimon@...oton.com,
	kwliu@...oton.com, yschu@...oton.com
Subject: Re: [PATCH v4 5/5] i3c: master: svc: Fix npcm845 DAA process
 corruption

On Mon, Feb 24, 2025 at 04:39:08PM +0800, Stanley Chu wrote:
> From: Stanley Chu <yschu@...oton.com>
>
> When MCONFIG.SKEW=0 and MCONFIG.ODHPP=0, the ENTDAA transaction gets
> corrupted and results in a no repeated-start condition at the end of
> address assignment.

If there are errata doc, provide a link will be appeciated.

>
> Workaround: Set MCONFIG.SKEW to 1 before initiating the DAA process.
> After the DAA process is completed, return MCONFIG.SKEW to its previous
> value.
>
> Signed-off-by: Stanley Chu <yschu@...oton.com>

Reviewed-by: Frank Li <Frank.Li@....com>

> ---
>  drivers/i3c/master/svc-i3c-master.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 4eb4b8888725..403d625e999e 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1162,7 +1162,16 @@ static int svc_i3c_master_do_daa(struct i3c_master_controller *m)
>  	}
>
>  	spin_lock_irqsave(&master->xferqueue.lock, flags);
> +
> +	if (svc_has_quirk(master, SVC_I3C_QUIRK_DAA_CORRUPT))
> +		writel(master->mctrl_config | SVC_I3C_MCONFIG_SKEW(1),
> +		       master->regs + SVC_I3C_MCONFIG);
> +
>  	ret = svc_i3c_master_do_daa_locked(master, addrs, &dev_nb);
> +
> +	if (svc_has_quirk(master, SVC_I3C_QUIRK_DAA_CORRUPT))
> +		writel(master->mctrl_config, master->regs + SVC_I3C_MCONFIG);
> +
>  	spin_unlock_irqrestore(&master->xferqueue.lock, flags);
>
>  	svc_i3c_master_clear_merrwarn(master);
> --
> 2.34.1
>