linux-kernel - Re: [PATCH] thermal/debugfs: replace kzalloc() with kcalloc() in thermal_debug_tz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4fe7f680-2189-48b1-b115-abcf1b9084e7@arm.com>
Date: Mon, 24 Feb 2025 16:37:37 +0000
From: Lukasz Luba <lukasz.luba@....com>
To: Ethan Carter Edwards <ethan@...ancedwards.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
 Markus Elfring <Markus.Elfring@....de>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>,
 linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] thermal/debugfs: replace kzalloc() with kcalloc() in
 thermal_debug_tz_add()

On 2/22/25 20:02, Ethan Carter Edwards wrote:
> We are trying to get rid of all multiplications from allocation
> functions to prevent integer overflows[1]. Here the multiplication is
> obviously safe, but using kcalloc() is more appropriate and improves
> readability. This patch has no effect on runtime behavior.
> 
> Link: https://github.com/KSPP/linux/issues/162 [1]
> Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
> 

IMO there is no need for such links in the patch header.
The explanation is enough. Just drop those two links
and should be good.

Thanks for the patch!

Regards,
Lukasz