linux-kernel - [PATCH v3 2/2] media: cadence: csi2rx: Enable csi2rx_err_irq interrupt and add support for VIDIOC_LOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250224023440.558827-1-changhuang.liang@starfivetech.com>
Date: Sun, 23 Feb 2025 18:34:40 -0800
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: y-abhilashchandra@...com
Cc: conor+dt@...nel.org,
	devarsht@...com,
	devicetree@...r.kernel.org,
	jai.luthra@...ux.dev,
	krzk+dt@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org,
	mchehab@...nel.org,
	mripard@...nel.org,
	r-donadkar@...com,
	robh@...nel.org,
	u-kumar1@...com,
	vaishnav.a@...com,
	changhuang.liang@...rfivetech.com
Subject: [PATCH v3 2/2] media: cadence: csi2rx: Enable csi2rx_err_irq interrupt and add support for VIDIOC_LOG_STATUS

Hi,  Abhilash

Thanks for the patch.

> Enable the csi2rx_err_irq interrupt to record any errors during streaming
> and also add support for VIDIOC_LOG_STATUS ioctl. The VIDIOC_LOG_STATUS
> ioctl can be invoked from user space to retrieve the device status,
> including details about any errors.
>
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@...com>

Looks ok to me!
Reviewed-by: Changhuang Liang <changhuang.liang@...rfivetech.com>

> ---
>
> Changes in v3:
> - Address Jai's review comment to enable FIFO overflow bits in the mask
>   only for the source pads that have an active remote.
> - Drop TI-specific interrupt and have support for only two interrupts
>   that are common across all vendors.
> - Address Changhuang's review to use pdev directly to get the interrupt.
> - Set the interrupt mask register only if the interrupt is defined in the DT.
>
>
>  drivers/media/platform/cadence/cdns-csi2rx.c | 125 +++++++++++++++++++
>  1 file changed, 125 insertions(+)

Best Regards,
Changhuang