linux-kernel - Re: [PATCH 1/2] drivers: watchdog: Add support for panic notifier callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH8PR18MB5381097A3ED6F33635EA9DDFC5C02@PH8PR18MB5381.namprd18.prod.outlook.com>
Date: Mon, 24 Feb 2025 04:09:56 +0000
From: George Cherian <gcherian@...vell.com>
To: Guenter Roeck <linux@...ck-us.net>,
        "wim@...ux-watchdog.org"
	<wim@...ux-watchdog.org>,
        "corbet@....net" <corbet@....net>
CC: "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] drivers: watchdog: Add support for panic notifier
 callback



> From: Guenter Roeck <groeck7@...il.com> On Behalf Of Guenter Roeck
> Sent: Friday, February 21, 2025 10:34 AM
> To: George Cherian <gcherian@...vell.com>; wim@...ux-watchdog.org; corbet@....net
> Cc: linux-watchdog@...r.kernel.org; linux-doc@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 1/2] drivers: watchdog: Add support for panic notifier callback

> On 2/20/25 18:35, George Cherian wrote:
>> Watchdog is not turned off in kernel panic situation.
>> In certain systems this might prevent the successful loading
>> of kdump kernel. The kdump kernel might hit a watchdog reset
>> while it is booting.
>> 
>> To avoid such scenarios add a panic notifier call back function
>> which can stop the watchdog. This provision can be enabled on per
>> driver basis if the user wishes to by setting the flag
>> WDOG_STOP_ON_PANIC from respective drivers.
>> 
>
> I think this makes sense in principal, but it should not be driver specific.

Thanks for the review. Will do the changes and post a v2.
>
>Guenter

-George