linux-kernel - Re: [PATCH v2 1/4] dt-bindings: reset: Add Armada8K reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BY3PR18MB467373E86423BA4615D6FF0FA7C02@BY3PR18MB4673.namprd18.prod.outlook.com>
Date: Mon, 24 Feb 2025 18:19:32 +0000
From: Wilson Ding <dingwei@...vell.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "gregory.clement@...tlin.com" <gregory.clement@...tlin.com>,
        "sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "conor+dt@...nel.org"
	<conor+dt@...nel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        Sanghoon Lee <salee@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: reset: Add Armada8K reset controller



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Sunday, February 23, 2025 12:49 AM
> To: Wilson Ding <dingwei@...vell.com>; Rob Herring <robh@...nel.org>
> Cc: linux-kernel@...r.kernel.org; devicetree@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; andrew@...n.ch; gregory.clement@...tlin.com;
> sebastian.hesselbarth@...il.com; krzk+dt@...nel.org; conor+dt@...nel.org;
> p.zabel@...gutronix.de; Sanghoon Lee <salee@...vell.com>;
> Geethasowjanya Akula <gakula@...vell.com>
> Subject: [EXTERNAL] Re: [PATCH v2 1/4] dt-bindings: reset: Add Armada8K
> reset controller
> 
> On 22/02/2025 21: 57, Wilson Ding wrote: >>>> + offset: >>>> + $ref:
> /schemas/types. yaml#/definitions/uint32 >>>> + description: Offset in the
> register map for the gpio registers >>>> + (in bytes)
> 
> On 22/02/2025 21:57, Wilson Ding wrote:
> 
> >>>> +  offset:
> >>>> +    $ref: /schemas/types.yaml#/definitions/uint32
> >>>> +    description: Offset in the register map for the gpio registers
> >>>> + (in bytes)
> >>>
> >>> That's neither correct nor needed. Your device knows ofsset based on
> >>> the compatible.
> >>
> >> Or use 'reg'.
> >>
> >> But really, just add #reset-cells to the parent node. There's no need
> >> for a child node here. The parent needs a specific compatible though.
> >>
> >
> > I am not inventing the 'offset' property. I just tried to follow the
> > other existing sub-nodes under the same parent node
> > (system-controller). The mvebu-gpio driver also uses 'offset' instead
> > of 'reg' for the syscon device (see below). But it
> 
> 
> You never answered why do you need offset and why it cannot work without.
> 

I see. You're right. I don't have to use 'offset'. The reason I choose 'offset' over
'reg' is that the Armada's GPIO driver use it. And I thought what was accepted
would be easier to be accepted again. I will change it in next version.

> > seems also not correct from your point of view. Now, I am a bit
> > confused what should be the right scheme for the Armada's
> > system-controller, including GPIO and Reset controller. And
> > dt_binding_check complains "system-controller@
> > 440000:  compatible: ['syscon', 'simple-mfd'] is too short". Can you
> > point me any  reference for me to fix these issues.
> 
> See all other syscon devices. 'git grep simple-mfd' or for syscon
> 
> 
> >
> > CP110_LABEL(syscon0): system-controller@...000 {
> > 	compatible = "syscon", "simple-mfd";
> > 	reg = <0x440000 0x1000>;
> 
> 
> Best regards,
> Krzysztof