linux-kernel - Re: [PATCH v2 1/2] arm64: dts: imx8mm: Add pinctrl config definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b905192e-6cbe-4d84-b31e-f14b47c3a698@kernel.org>
Date: Mon, 24 Feb 2025 09:03:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Maud Spierings | GOcontroll <maudspierings@...ontroll.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] arm64: dts: imx8mm: Add pinctrl config definitions

On 24/02/2025 08:39, Maud Spierings | GOcontroll wrote:
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Sunday, February 23, 2025 11:27 AM
>  
>> On Tue, Feb 18, 2025 at 09:39:16AM +0100, Maud Spierings wrote:
>>> Currently to configure each IOMUXC_SW_PAD_CTL_PAD the raw value of this
>>> register is written in the dts, these values are not obvious. Add defines
>>> which describe the fields of this register which can be or-ed together to
>>> produce readable settings.
>>>
>>> Signed-off-by: Maud Spierings <maudspierings@...ontroll.com>
>>> ---
>>>   arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h | 27 ++++++++++++++++++++++++++
>>>   1 file changed, 27 insertions(+)
>>>
> 
>> Why are you adding defines which have no users? This is just dead code.
> 
> I will be sending more patches in the near future that will use these bindings, the total stack of patches is starting to grow though so I'm trying to spread it out in multiple easy to manage bits.
> It is also a bit of a test if I can continue using these defines as I plan, or if that will not be accepted and I should instead revert to using raw hex values.

Please wrap your replies.

> 
> If this is a problem then I will keep it in the larger patchset that is to come.

Defines without users is dead code. It's not even easy to validate if
they make any sense without seeing how they are used.

Best regards,
Krzysztof