linux-kernel - Re: [PATCH RESEND v6 2/4] input: apple_z2: Add a driver for Apple Z2 touchscreens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73D7DB60-6265-4071-BE2A-FBBE86340476@live.com>
Date: Mon, 24 Feb 2025 08:04:24 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: "fnkl.kernel@...il.com" <fnkl.kernel@...il.com>
CC: Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>, Alyssa
 Rosenzweig <alyssa@...enzweig.io>, Dmitry Torokhov
	<dmitry.torokhov@...il.com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Henrik
 Rydberg <rydberg@...math.org>, "asahi@...ts.linux.dev"
	<asahi@...ts.linux.dev>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Janne Grunau <j@...nau.net>, Neal Gompa
	<neal@...pa.dev>
Subject: Re: [PATCH RESEND v6 2/4] input: apple_z2: Add a driver for Apple Z2
 touchscreens


Hi

> On 17 Feb 2025, at 5:08 PM, Sasha Finkelstein via B4 Relay <devnull+fnkl.kernel.gmail.com@...nel.org> wrote:
> 
> From: Sasha Finkelstein <fnkl.kernel@...il.com>
> 
> Adds a driver for Apple touchscreens using the Z2 protocol.
> 
> Signed-off-by: Janne Grunau <j@...nau.net>
> Reviewed-by: Neal Gompa <neal@...pa.dev>
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@...il.com>
> ---
> drivers/input/touchscreen/Kconfig    |  13 +
> drivers/input/touchscreen/Makefile   |   1 +
> drivers/input/touchscreen/apple_z2.c | 473 +++++++++++++++++++++++++++++++++++
> 3 files changed, 487 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 1a03de7fcfa66c0f60768be17d776a79e36e570e..6c885cc58f323b3628538d41460248f8ab1dbf7d 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -103,6 +103,19 @@ config TOUCHSCREEN_ADC
>  To compile this driver as a module, choose M here: the
>  module will be called resistive-adc-touch.ko.
> 
> +config TOUCHSCREEN_APPLE_Z2
> + tristate "Apple Z2 touchscreens"
> + default ARCH_APPLE
> + depends on SPI
> + help
> +  Say Y here if you have an Apple device with
> +  a touchscreen or a touchbar.

If I understood correctly, this driver is for arm Mac’s Touch Bar.
Probably mention the same here, since we have separate drivers for x86 Macs upstream.

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/hid?h=next-20250221&id=1fd41e5e3d7cc556e43f4162ca28a41f4896c6ad

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/hid?h=next-20250221&id=8e9b9152cfbdc2a90a8acb68acbc1407ef67d139
> +
> +  If unsure, say N.
> +
> +  To compile this driver as a module, choose M here: the
> +  module will be called apple_z2.