linux-kernel - Re: [PATCH v10 3/6] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03157f06-8e80-470c-bdee-ffbb31627a9c@quicinc.com>
Date: Mon, 24 Feb 2025 15:24:10 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, <andersson@...nel.org>,
        <mturquette@...libre.com>, <sboyd@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <konradybcio@...nel.org>,
        <catalin.marinas@....com>, <will@...nel.org>, <p.zabel@...gutronix.de>,
        <richardcochran@...il.com>, <geert+renesas@...der.be>,
        <dmitry.baryshkov@...aro.org>, <arnd@...db.de>,
        <nfraprado@...labora.com>, <quic_tdas@...cinc.com>,
        <biju.das.jz@...renesas.com>, <elinor.montmasson@...oirfairelinux.com>,
        <ross.burton@....com>, <javier.carrasco@...fvision.net>,
        <quic_anusha@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <netdev@...r.kernel.org>
CC: <quic_srichara@...cinc.com>, <quic_varada@...cinc.com>
Subject: Re: [PATCH v10 3/6] dt-bindings: clock: Add ipq9574 NSSCC clock and
 reset definitions



On 2/21/2025 5:19 PM, Konrad Dybcio wrote:
> On 21.02.2025 11:14 AM, Manikanta Mylavarapu wrote:
>> From: Devi Priya <quic_devipriy@...cinc.com>
>>
>> Add NSSCC clock and reset definitions for ipq9574.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> Signed-off-by: Devi Priya <quic_devipriy@...cinc.com>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>> ---
> 
> [...]
> 
>> +  - |
>> +    #include <dt-bindings/clock/qcom,ipq9574-gcc.h>
>> +    #include <dt-bindings/clock/qcom,ipq-cmn-pll.h>
>> +    clock-controller@...00000 {
>> +      compatible = "qcom,ipq9574-nsscc";
>> +      reg = <0x39b00000 0x80000>;
>> +      clocks = <&xo_board_clk>,
>> +               <&cmn_pll NSS_1200MHZ_CLK>,
>> +               <&cmn_pll PPE_353MHZ_CLK>,
>> +               <&gcc GPLL0_OUT_AUX>,
>> +               <&uniphy 0>,
>> +               <&uniphy 1>,
>> +               <&uniphy 2>,
>> +               <&uniphy 3>,
>> +               <&uniphy 4>,
>> +               <&uniphy 5>,
>> +               <&gcc GCC_NSSCC_CLK>;
>> +      clock-names = "xo",
>> +                    "nss_1200",
>> +                    "ppe_353",
>> +                    "gpll0_out",
>> +                    "uniphy0_rx",
>> +                    "uniphy0_tx",
>> +                    "uniphy1_rx",
>> +                    "uniphy1_tx",
>> +                    "uniphy2_rx",
>> +                    "uniphy2_tx",
>> +                    "nsscc";
> 
> I see that the input clock is named rather non-descriptively, but maybe
> we should call it something like "bus" so that it has more meaning to
> the reader

Hi Konrad,

Thank you for reviewing the patch.
I will rename the 'nsscc' clock to 'bus' in the next version.

Thanks & Regards,
Manikanta.