linux-kernel - Re: [PATCH v3] serial: 8250: Fix fifo underflow on flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7xjiPA7nziASvC7-jkeeping@inmusicbrands.com>
Date: Mon, 24 Feb 2025 12:18:16 +0000
From: John Keeping <jkeeping@...usicbrands.com>
To: Wentao Guan <guanwentao@...ontech.com>
Cc: andriy.shevchenko@...ux.intel.com, arnd@...db.de,
	fancer.lancer@...il.com, ftoth@...londelft.nl,
	gregkh@...uxfoundation.org, heikki.krogerus@...ux.intel.com,
	ilpo.jarvinen@...ux.intel.com, jirislaby@...nel.org,
	john.ogness@...utronix.de, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, pmladek@...e.com,
	schnelle@...ux.ibm.com, stable@...r.kernel.org,
	sunilvl@...tanamicro.com
Subject: Re: [PATCH v3] serial: 8250: Fix fifo underflow on flush

On Sat, Feb 22, 2025 at 09:26:27PM +0800, Wentao Guan wrote:
> It seems strange that call 'dmaengine_terminate_async( **dma->rxchan** );' in
> 'serial8250_ **tx** _dma_flush' during code review.
> I am not a professional reviewer in this module, could you explaim the change?

It's a typo!  Nice catch, I will send a patch to fix this.


Regards,
John