linux-kernel - Re: [PATCH 2/2] ASoC: codecs: Add aw88166 amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32992dc7-15a1-4ca5-a5a1-e7e26ce74fbc@web.de>
Date: Tue, 25 Feb 2025 14:09:39 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Weidong Wang <wangweidong.a@...nic.com>, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Ben Yi <yijiangtao@...nic.com>,
 Binbin Zhou <zhoubinbin@...ngson.cn>, Conor Dooley <conor+dt@...nel.org>,
 Igor Prusov <ivprusov@...utedevices.com>, Jack Yu <jack.yu@...ltek.com>,
 Jaroslav Kysela <perex@...ex.cz>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Nuno Sá <nuno.sa@...log.com>,
 Paul Handrigan <paulha@...nsource.cirrus.com>,
 Prasad Kumpatla <quic_pkumpatl@...cinc.com>,
 Richard Fitzgerald <rf@...nsource.cirrus.com>, Rob Herring
 <robh@...nel.org>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 2/2] ASoC: codecs: Add aw88166 amplifier driver

…
> The driver is for amplifiers aw88166 of Awinic Technology
…

You may occasionally put more than 57 characters into text lines
of such a change description.


See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc4#n94


…
> +++ b/sound/soc/codecs/aw88166.c
> @@ -0,0 +1,1937 @@
…
> +static int aw_dev_dsp_read(struct aw_device *aw_dev,
+		unsigned short dsp_addr, unsigned int *dsp_data, unsigned char data_type)
> +{
…
> +	mutex_lock(&aw_dev->dsp_lock);
> +	switch (data_type) {
> +	case AW88166_DSP_16_DATA:
…
> +	mutex_unlock(&aw_dev->dsp_lock);
> +
> +	return ret;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&aw_dev->dsp_lock);”?
https://elixir.bootlin.com/linux/v6.14-rc4/source/include/linux/mutex.h#L201

Regards,
Markus