linux-kernel - Re: [PATCH V1 2/2] ASoC: codecs: Add aw88166 amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0dd44da7-b3e3-4639-9acb-a296cba03b68@kernel.org>
Date: Tue, 25 Feb 2025 09:17:27 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: wangweidong.a@...nic.com
Cc: broonie@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
 ivprusov@...utedevices.com, jack.yu@...ltek.com, krzk+dt@...nel.org,
 lgirdwood@...il.com, linux-kernel@...r.kernel.org,
 linux-sound@...r.kernel.org, nuno.sa@...log.com,
 paulha@...nsource.cirrus.com, perex@...ex.cz, quic_pkumpatl@...cinc.com,
 rf@...nsource.cirrus.com, robh@...nel.org, tiwai@...e.com,
 yijiangtao@...nic.com, zhoubinbin@...ngson.cn
Subject: Re: [PATCH V1 2/2] ASoC: codecs: Add aw88166 amplifier driver

On 25/02/2025 08:42, wangweidong.a@...nic.com wrote:
> Thank you very much for your review
> 
> On Fri, Feb 23, 2025 at 12:46:14 +0100, krzk@...nel.org wrote:
>> On Fri, Feb 21, 2025 at 06:26:23PM +0800, wangweidong.a@...nic.com wrote:
>>> +
>>> +static void aw88166_hw_reset(struct aw88166 *aw88166)
>>> +{
>>> +	if (aw88166->reset_gpio) {
>>> +		gpiod_set_value_cansleep(aw88166->reset_gpio, 1);
>>> +		usleep_range(AW88166_1000_US, AW88166_1000_US + 10);
>>> +		gpiod_set_value_cansleep(aw88166->reset_gpio, 0);
>>> +		usleep_range(AW88166_1000_US, AW88166_1000_US + 10);
>>> +		gpiod_set_value_cansleep(aw88166->reset_gpio, 1);
> 
>> Why do you keep reset as active after reset? How is it suppose to work?
> 
> The gpio port of the AW88166 is reset when it is low.

The value here is not value on the pin, but logical value for Linux. 1
means make it active.

> So it's working now, I will modify it as follows:

Really? Your DTS example has ACTIVE_LOW, so with combination of above it
cannot work. Unless this is wrong or your DTS is wrong or this is not
reset but "enable" pin etc.


Best regards,
Krzysztof