linux-kernel - Re: [PATCH v3 2/2] dt-bindings: iio: filter: Add lpf/hpf freq margins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z73KUzqe5VmITJVB@65YTFL3.secure.tethers.com>
Date: Tue, 25 Feb 2025 08:49:07 -0500
From: Sam Winchenbach <sam.winchenbach@...mepointer.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	antoniu.miclaus@...log.com, lars@...afoo.de,
	Michael.Hennerich@...log.com, jic23@...nel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: filter: Add lpf/hpf freq margins

On Tue, Feb 25, 2025 at 08:42:04AM +0100, Krzysztof Kozlowski wrote:
> On 24/02/2025 18:50, Sam Winchenbach wrote:
> > Adds two properties to add a margin when automatically finding the
> > corner frequencies.
> > 
> > Signed-off-by: Sam Winchenbach <sam.winchenbach@...mepointer.org>
> 
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> 
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
> 
> Please kindly resend and include all necessary To/Cc entries.
> </form letter>

Updated the maintainers list per your instruction and resubmitted as v4.
Thank you for your assistance.

> 
> > ---
> >  .../devicetree/bindings/iio/filter/adi,admv8818.yaml | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> > index b77e855bd594..1be6f1fe4bfc 100644
> > --- a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> > +++ b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> > @@ -44,6 +44,16 @@ properties:
> >    '#clock-cells':
> >      const: 0
> >  
> > +  adi,lpf-margin-hz:
> > +    description:
> > +      Sets minimum low-pass corner frequency to the frequency of rf_in plus this value when in auto mode.
> 
> Wrap according to coding style.

Updated in the v4 patch.

> 
> 
> 
> Best regards,
> Krzysztof