linux-kernel - Re: [PATCH v3 2/2] dt-bindings: iio: filter: Add lpf/hpf freq margins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe1b0dde-f899-4303-bd2a-b19098edcae8@kernel.org>
Date: Tue, 25 Feb 2025 08:42:04 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sam Winchenbach <sam.winchenbach@...mepointer.org>,
 linux-kernel@...r.kernel.org
Cc: linux-iio@...r.kernel.org, antoniu.miclaus@...log.com, lars@...afoo.de,
 Michael.Hennerich@...log.com, jic23@...nel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: filter: Add lpf/hpf freq margins

On 24/02/2025 18:50, Sam Winchenbach wrote:
> Adds two properties to add a margin when automatically finding the
> corner frequencies.
> 
> Signed-off-by: Sam Winchenbach <sam.winchenbach@...mepointer.org>

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

> ---
>  .../devicetree/bindings/iio/filter/adi,admv8818.yaml | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> index b77e855bd594..1be6f1fe4bfc 100644
> --- a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> +++ b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> @@ -44,6 +44,16 @@ properties:
>    '#clock-cells':
>      const: 0
>  
> +  adi,lpf-margin-hz:
> +    description:
> +      Sets minimum low-pass corner frequency to the frequency of rf_in plus this value when in auto mode.

Wrap according to coding style.

Best regards,
Krzysztof