linux-kernel - Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3337030.aeNJFYEL58@trenzalore>
Date: Tue, 25 Feb 2025 09:58:23 -0500
From: Detlev Casanova <detlev.casanova@...labora.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc: Piotr Oniszczuk <piotr.oniszczuk@...il.com>, linux-kernel@...r.kernel.org,
 Algea Cao <algea.cao@...k-chips.com>, Heiko Stuebner <heiko@...ech.de>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 dri-devel@...ts.freedesktop.org, Niklas Cassel <cassel@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>, kernel@...labora.com,
 David Airlie <airlied@...il.com>, Dragan Simic <dsimic@...jaro.org>,
 Simona Vetter <simona@...ll.ch>, Rob Herring <robh@...nel.org>,
 Robert Foss <rfoss@...nel.org>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Sugar Zhang <sugar.zhang@...k-chips.com>, linux-rockchip@...ts.infradead.org,
 Chen-Yu Tsai <wens@...e.org>, FUKAUMI Naoki <naoki@...xa.com>,
 devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
 Jonas Karlman <jonas@...boo.se>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Johan Jonker <jbx6244@...il.com>, linux-arm-kernel@...ts.infradead.org,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Alexey Charkov <alchark@...il.com>, Thomas Zimmermann <tzimmermann@...e.de>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

Hi Morimoto-san,

On Tuesday, 25 February 2025 01:16:50 EST Kuninori Morimoto wrote:
> Hi Detlev, again
> 
> > > Especially those commits:
> > >       ASoC: audio-graph-card2: use __free(device_node) for device node
> > >       ASoC: audio-graph-card: use __free(device_node) for device node
> > >       ASoC: simple-card: use __free(device_node) for device node
> > 
> > I got same report from our test team. I'm now tring to solve it.
> 
> Unfortunately, I can't reproduce the issue on my environment,
> but I guess I found the root cause. Does attached patch can solve
> your issue ?

>From what I see, the error is not present anymore on linux 6.14-rc4. I tried 
reverting your patch "ASoC: simple-card-utils.c: add missing dlc->of_node" 
(dabbd325b25edb5cdd99c94391817202dd54b651) and the error reappears.

On 6.14-rc3, any of your patches (dabbd325b25e, or the one you attached here) 
will fix the issue and on 6.14-rc4, there is already a patch that fixes the 
issue.

Also, since dabbd325b25e, the node indeed should be kept while the driver is 
used. So even though the issue reported here is fixed by another patch, both 
are likely needed.

That being said, I'm not sure I completely understand why that extra line fixes 
the issue. Is the __free() attribute smart enough to know that the pointer has 
been copied and not free it at the end of scope ?

> I will officially post the patch to ML, but want to confirm it before it.
> 
> Thank you for your help !!

Thank you for looking into this too :)

Detlev.