linux-kernel - Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h64hh5hz.wl-kuninori.morimoto.gx@renesas.com>
Date: Wed, 26 Feb 2025 01:14:16 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Detlev Casanova <detlev.casanova@...labora.com>
Cc: Thomas Zimmermann <tzimmermann@...e.de>,
	Sugar Zhang <sugar.zhang@...k-chips.com>,
	Simona Vetter <simona@...ll.ch>,
	Sebastian Reichel <sebastian.reichel@...labora.com>,
	Robert Foss <rfoss@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Piotr Oniszczuk <piotr.oniszczuk@...il.com>,
	Niklas Cassel <cassel@...nel.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Maxime Ripard <mripard@...nel.org>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	Linux-DT <devicetree@...r.kernel.org>,
	Linux-ARM <linux-arm-kernel@...ts.infradead.org>,
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Jonas Karlman <jonas@...boo.se>,
	Johan Jonker <jbx6244@...il.com>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Heiko Stuebner <heiko@...ech.de>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	FUKAUMI Naoki <naoki@...xa.com>,
	Dragan Simic <dsimic@...jaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	David Airlie <airlied@...il.com>,
	Conor Dooley <conor+dt@...nel.org>,
	Chen-Yu Tsai <wens@...e.org>,
	Andrzej Hajda <andrzej.hajda@...el.com>,
	Algea Cao <algea.cao@...k-chips.com>,
	Alexey Charkov <alchark@...il.com>,
	linux-rockchip@...ts.infradead.org,
	kernel@...labora.com,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC


Hi Detlev

Thank you for the testing.

> I got same report from our test team. I'm now tring to solve it.

It seems our test team and your team are encounter same issues by different
way, and it seems it happen if some kind of deffer issue happen (?).

> That being said, I'm not sure I completely understand why that extra line fixes 
> the issue. Is the __free() attribute smart enough to know that the pointer has 
> been copied and not free it at the end of scope ?

__free(device_node) attribute will automatically calls of_node_put() when it
lost the scope. By below patch, graph_util_parse_dai() will use
__free(device_node) and thus dlc->of_node counter was not increased.

	419d1918105e5d9926ab02f1f834bb416dc76f65
	("ASoC: simple-card-utils: use __free(device_node) for device node")

In such situation, if some kind of deffer issue happened, xxx-card probe()
will failed and calls simple_util_clean_reference(). It calls of_node_put()
for each dlc->of_node, but above one was already called of_node_put() via
__free(device_node). So you encounter the error.

I'm not 100% sure why dabbd325b2 commit removed the issue, but I think
it is just luck, I think.

Thank you for your test !!
I will post the patch with below tag if our test team could confirm it.

	Tested-by: Detlev Casanova <detlev.casanova@...labora.com>

Best regards
---
Kuninori Morimoto