linux-kernel - Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4066857-01e7-4172-b141-4c5f8bb3540b@molgen.mpg.de>
Date: Tue, 25 Feb 2025 22:11:54 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Eason Yang <j2anfernee@...il.com>
Cc: avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
 venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
 jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, nuno.sa@...log.com, dlechner@...libre.com,
 javier.carrasco.cruz@...il.com, andriy.shevchenko@...ux.intel.com,
 gstols@...libre.com, olivier.moysan@...s.st.com, mitrutzceclan@...il.com,
 tgamblin@...libre.com, matteomartelli3@...il.com,
 marcelo.schmitt@...log.com, alisadariana@...il.com,
 joao.goncalves@...adex.com, thomas.bonnefille@...tlin.com,
 ramona.nechita@...log.com, herve.codina@...tlin.com,
 chanh@...amperecomputing.com, kwliu@...oton.com, yhyang2@...oton.com,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 openbmc@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201

Dear Eason,


Thank you for your patch.

Am 21.02.25 um 10:09 schrieb Eason Yang:
> Add Nuvoton NCT7201/NCT7202 system voltage monitor 12-bit ADC driver
> 
> NCT7201/NCT7202 supports up to 12 analog voltage monitor inputs and up to
> 4 SMBus addresses by ADDR pin. Meanwhile, ALERT# hardware event pins for
> independent alarm signals, and the all threshold values could be set for

… and all the threshold values …

> system protection without any timing delay. It also supports reset input
> RSTIN# to recover system from a fault condition.
> 
> Currently, only single-edge mode conversion and threshold events support.

… are supported.

It’d be great if you added a datasheet name and revision, and, if 
publicly available, a URL.

> Signed-off-by: Eason Yang <j2anfernee@...il.com>
> ---
>   MAINTAINERS               |   1 +
>   drivers/iio/adc/Kconfig   |  11 +
>   drivers/iio/adc/Makefile  |   1 +
>   drivers/iio/adc/nct7201.c | 487 ++++++++++++++++++++++++++++++++++++++
>   4 files changed, 500 insertions(+)
>   create mode 100644 drivers/iio/adc/nct7201.c

[…]


Kind regards,

Paul