linux-kernel - Re: [PATCH v4 1/2] dt-bindings: iio: adc: add NCT7201 ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+4VgcK=R=BF-qk4w-pLkwbTypgMmpJ=7joYN8nioT2Dx3_Z7w@mail.gmail.com>
Date: Mon, 7 Apr 2025 21:41:19 +0800
From: Yu-Hsian Yang <j2anfernee@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com, 
	venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com, 
	jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, nuno.sa@...log.com, javier.carrasco.cruz@...il.com, 
	andriy.shevchenko@...ux.intel.com, gstols@...libre.com, 
	olivier.moysan@...s.st.com, mitrutzceclan@...il.com, tgamblin@...libre.com, 
	matteomartelli3@...il.com, marcelo.schmitt@...log.com, alisadariana@...il.com, 
	joao.goncalves@...adex.com, thomas.bonnefille@...tlin.com, 
	ramona.nechita@...log.com, herve.codina@...tlin.com, 
	chanh@...amperecomputing.com, KWLIU@...oton.com, yhyang2@...oton.com, 
	openbmc@...ts.ozlabs.org, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: adc: add NCT7201 ADCs

Dear David Lechner,

Thanks again for the review, I'll do the changes here and send next patch.

David Lechner <dlechner@...libre.com> 於 2025年2月21日 週五 下午11:56寫道：
>
> On 2/21/25 3:09 AM, Eason Yang wrote:
> > Add a binding specification for the Nuvoton NCT7201/NCT7202 up to 12-bit
> > ADCs with I2C interface.
> >
> > Signed-off-by: Eason Yang <j2anfernee@...il.com>
> > ---
> >  .../bindings/iio/adc/nuvoton,nct7201.yaml     | 57 +++++++++++++++++++
> >  MAINTAINERS                                   |  1 +
> >  2 files changed, 58 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml
> > new file mode 100644
> > index 000000000000..830c37fd9f22
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml
> > @@ -0,0 +1,57 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/adc/nuvoton,nct7201.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Nuvoton nct7201 and similar ADCs
> > +
> > +maintainers:
> > +  - Eason Yang <j2anfernee@...il.com>
> > +
> > +description: |
> > +  The NCT7201/NCT7202 is a Nuvoton Hardware Monitor IC, contains up to 12 voltage
> > +  monitoring channels, with SMBus interface, and up to 4 sets SMBus address
> > +  selection by ADDR connection. It also provides ALERT# signal for event
> > +  notification and reset input RSTIN# to recover it from a fault condition.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - nuvoton,nct7201
> > +      - nuvoton,nct7202
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +
>
> Maybe this was brought up before, but no power supply?
>

  vdd-supply:
    description:
      A 3.3V to supply that powers the chip.

  vref-supply:
    description:
      The regulator supply for the ADC reference voltage.

> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        adc@1d {
> > +            compatible = "nuvoton,nct7202";
> > +            reg = <0x1d>;

            vdd-supply = <&vdd>;
            vref-supply = <&vref>;

> > +            interrupt-parent = <&gpio3>;
> > +            interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> > +            reset-gpios = <&gpio3 28 GPIO_ACTIVE_LOW>;
> > +        };
> > +    };
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 3864d473f52f..fdc4aa5c7eff 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -2831,6 +2831,7 @@ L:      openbmc@...ts.ozlabs.org (moderated for non-subscribers)
> >  S:   Supported
> >  F:   Documentation/devicetree/bindings/*/*/*npcm*
> >  F:   Documentation/devicetree/bindings/*/*npcm*
> > +F:   Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml

Remove F:   Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml
>
> This (ARM/NUVOTON NPCM ARCHITECTURE) doesn't look like the right place for
> adding a stand-alone chip. You will need to start a new section like:
>
> NUVOTON NCT7201 IIO DRIVER
>

NUVOTON NCT7201 IIO DRIVER
M: Eason Yang <j2anfernee@...il.com>
L: linux-iio@...r.kernel.org
S: Maintained
F: Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml
F: drivers/iio/adc/nct7201.c

> >  F:   Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
> >  F:   arch/arm/boot/dts/nuvoton/nuvoton-npcm*
> >  F:   arch/arm/mach-npcm/
>