[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CA+4VgcJL7pi6y55N6QaUKNkOTqTKkF8dAo+5syvRCbx7gW+ehQ@mail.gmail.com>
Date: Mon, 7 Apr 2025 21:51:41 +0800
From: Yu-Hsian Yang <j2anfernee@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
nuno.sa@...log.com, dlechner@...libre.com, javier.carrasco.cruz@...il.com,
andriy.shevchenko@...ux.intel.com, gstols@...libre.com,
olivier.moysan@...s.st.com, mitrutzceclan@...il.com, tgamblin@...libre.com,
matteomartelli3@...il.com, marcelo.schmitt@...log.com, alisadariana@...il.com,
joao.goncalves@...adex.com, thomas.bonnefille@...tlin.com,
ramona.nechita@...log.com, herve.codina@...tlin.com,
chanh@...amperecomputing.com, KWLIU@...oton.com, yhyang2@...oton.com,
openbmc@...ts.ozlabs.org, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/2] iio: adc: add Nuvoton NCT7201 ADC driver
Dear Jonathan,
Thanks again for the review
Jonathan Cameron <jic23@...nel.org> 於 2025年2月22日 週六 下午11:25寫道:
>
> On Fri, 21 Feb 2025 17:09:16 +0800
> Eason Yang <j2anfernee@...il.com> wrote:
>
> Hi Eason,
>
> Not sure if I asked this before, but this is a device that seems
> to be typically used for hardware monitoring and there are a number
> of similar sounding device in drivers/hwmon/
>
> That raises a couple of questions:
> 1) Is it compatible with any of those existing drivers?
No, we need a new driver to do the ADC conversion for NCT7201/NCT7202.
> 2) Why IIO rather than HWMON?
A driver for NCT7201 with more functionality is available in the iio
adc subsystem.
If the chip is used for hardware monitoring, the iio->hwmon bridge
should be used.
>
> There isn't normally a problem with having a hardware monitoring
> related device supported by IIO, it is just good to know if your
> usecase makes that a good idea. We have the iio-hwmon bridge
> driver to solve the problem of a device than can be used either
> as a generic ADC or as a hwmon type monitoring device (which tends
> to have more alarms etc)
Yes, we also verify the iio-hwmon bridge.
>
> Jonathan
>
>
> > Change since version 4:
> > - Fix comments
> > - Add interrupts and reset-gpios to the DT example
> > - Use the FIELD_PREP and FIELD_GET
> > - Add use_single_write in regmap_config
> > - Use regmap_access_table
> >
> > Change since version 3:
> > - Fix comments
> > - Don't put nct720"x" in the name, just call it nct7201
> > - Remove differential inputs until conversions are finished
> > - Add NCT7201_ prefix in all macros and avoid the tables
> > - Correct event threshold values in raw units
> > - Add with and without interrupt callback function to have the event
> > config part and one that doesn't
> > - Remove print an error message if regmap_wirte failed case
> >
> > Change since version 2:
> > - Remvoe read-vin-data-size property, default use read word vin data
> > - Use regmap instead of i2c smbus API
> > - IIO should be IIO_CHAN_INFO_RAW and _SCALE not _PROCESSED
> > - Use dev_xxx_probe in probe function and dev_xxx in other functions
> > - Use devm_iio_device_register replace of iio_device_register
> > - Use guard(mutex) replace of mutex_lock
> > - Use get_unaligned_le16 conversion API
> >
> > Changes since version 1:
> > - Add new property in iio:adc binding document
> > - Add new driver for Nuvoton NCT720x driver
> >
> > Eason Yang (2):
> > dt-bindings: iio: adc: add NCT7201 ADCs
> > iio: adc: add support for Nuvoton NCT7201
> >
> > .../bindings/iio/adc/nuvoton,nct7201.yaml | 57 ++
> > MAINTAINERS | 2 +
> > drivers/iio/adc/Kconfig | 11 +
> > drivers/iio/adc/Makefile | 1 +
> > drivers/iio/adc/nct7201.c | 487 ++++++++++++++++++
> > 5 files changed, 558 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml
> > create mode 100644 drivers/iio/adc/nct7201.c
> >
>
Powered by blists - more mailing lists