linux-kernel - Re: [PATCH] platform/x86: asus-wmi: change quiet to low-power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d67e31ce334085b815f79f9c57a2c4e35870423.camel@ljones.dev>
Date: Tue, 25 Feb 2025 19:13:29 +1300
From: Luke Jones <luke@...nes.dev>
To: Mario Limonciello <mario.limonciello@....com>, 
	platform-driver-x86@...r.kernel.org
Cc: corentin.chary@...il.com, hdegoede@...hat.com, 
	ilpo.jarvinen@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: asus-wmi: change quiet to low-power

On Mon, 2025-02-24 at 18:39 -0800, Mario Limonciello wrote:
> On 2/24/2025 16:35, Luke Jones wrote:
> > From: "Luke D. Jones" <luke@...nes.dev>
> > 
> > Change the profile name "quiet" to "low-power" to match the AMD
> > name. The
> > primary reason for this is to match AMD naming for
> > platform_profiles and
> > allow both to match. It does not affect Intel machines.
> > 
> > The quiet profile is essentially a low-power profile which tweaks
> > both TDP and fans - this applies to 80+ ASUS laptops.
> > 
> > Signed-off-by: Luke D. Jones <luke@...nes.dev>
> 
> Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> 
> IMO - this should have a fixes tag since this should probably go in
> the 
> 6.14 cycle too.
> 
> Fixes: 688834743d67 ("ACPI: platform_profile: Allow multiple
> handlers")
> 

Good point, thanks. I assume when pulled in this can be added?

> > ---
> >   drivers/platform/x86/asus-wmi.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/asus-wmi.c
> > b/drivers/platform/x86/asus-wmi.c
> > index d22748f1e154..de19c3b3d8fb 100644
> > --- a/drivers/platform/x86/asus-wmi.c
> > +++ b/drivers/platform/x86/asus-wmi.c
> > @@ -3945,7 +3945,7 @@ static int
> > asus_wmi_platform_profile_get(struct device *dev,
> >   		*profile = PLATFORM_PROFILE_PERFORMANCE;
> >   		break;
> >   	case ASUS_THROTTLE_THERMAL_POLICY_SILENT:
> > -		*profile = PLATFORM_PROFILE_QUIET;
> > +		*profile = PLATFORM_PROFILE_LOW_POWER;
> >   		break;
> >   	default:
> >   		return -EINVAL;
> > @@ -3969,7 +3969,7 @@ static int
> > asus_wmi_platform_profile_set(struct device *dev,
> >   	case PLATFORM_PROFILE_BALANCED:
> >   		tp = ASUS_THROTTLE_THERMAL_POLICY_DEFAULT;
> >   		break;
> > -	case PLATFORM_PROFILE_QUIET:
> > +	case PLATFORM_PROFILE_LOW_POWER:
> >   		tp = ASUS_THROTTLE_THERMAL_POLICY_SILENT;
> >   		break;
> >   	default:
> > @@ -3982,7 +3982,7 @@ static int
> > asus_wmi_platform_profile_set(struct device *dev,
> >   
> >   static int asus_wmi_platform_profile_probe(void *drvdata,
> > unsigned long *choices)
> >   {
> > -	set_bit(PLATFORM_PROFILE_QUIET, choices);
> > +	set_bit(PLATFORM_PROFILE_LOW_POWER, choices);
> >   	set_bit(PLATFORM_PROFILE_BALANCED, choices);
> >   	set_bit(PLATFORM_PROFILE_PERFORMANCE, choices);
> >   
>