linux-kernel - Re: [PATCH 3/3] riscv: dts: sophgo: add Sophgo SPI NOR controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MAZPR01MB9162FA24821C3E02472CF028FEC32@MAZPR01MB9162.INDPRD01.PROD.OUTLOOK.COM>
Date: Tue, 25 Feb 2025 08:44:04 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Inochi Amaoto <inochiama@...il.com>, Longbin Li <looong.bin@...il.com>
Cc: linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
 sophgo@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Paul Walmsley
 <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>,
 Albert Ou <aou@...s.berkeley.edu>
Subject: Re: [PATCH 3/3] riscv: dts: sophgo: add Sophgo SPI NOR controller
 driver


On 2025/2/25 8:38, Inochi Amaoto wrote:
> On Tue, Feb 25, 2025 at 08:23:36AM +0800, Chen Wang wrote:
>> On 2025/2/24 18:12, Longbin Li wrote:
>>> Add SPI NOR device node for Sophgo.
>>>
>>> Signed-off-by: Longbin Li <looong.bin@...il.com>
>>> ---
>>>    .../boot/dts/sophgo/sg2044-sophgo-sd3-10.dts  | 18 ++++++++++++++
>>>    arch/riscv/boot/dts/sophgo/sg2044.dtsi        | 24 +++++++++++++++++++
>>>    2 files changed, 42 insertions(+)
>>>
>>> diff --git a/arch/riscv/boot/dts/sophgo/sg2044-sophgo-sd3-10.dts b/arch/riscv/boot/dts/sophgo/sg2044-sophgo-sd3-10.dts
>>> index c50e61a50013..9c634920f37e 100644
>>> --- a/arch/riscv/boot/dts/sophgo/sg2044-sophgo-sd3-10.dts
>>> +++ b/arch/riscv/boot/dts/sophgo/sg2044-sophgo-sd3-10.dts
>>> @@ -80,6 +80,24 @@ &sd {
>>>    	status = "okay";
>>>    };
>>>
>>> +&spifmc0 {
>>> +	status = "okay";
>>> +
>>> +	flash@0 {
>>> +		compatible = "jedec,spi-nor";
>>> +		reg = <0>;
>>> +	};
>>> +};
>>> +
>>> +&spifmc1 {
>>> +	status = "okay";
>>> +
>>> +	flash@0 {
>>> +		compatible = "jedec,spi-nor";
>>> +		reg = <0>;
>>> +	};
>>> +};
>>> +
>>>    &uart1 {
>>>    	status = "okay";
>>>    };
>> What is your baseline? I can't see "sg2044-sophgo-sd3-10.dts " on the latest
>> mainline yet.
>>
> It seems like he forgot to remove this patch as the baseline is not
> submitted.
>
>> BTW,  the name "sg2044-sophgo-sd3-10" seems a bit redundant. Wouldn't
>> "sg2044-sd3-10" be better?
>>
> I do not think so. we want <soc-vendor-board> format. In this format.
> sophgo is a must.

All these dts* files are under "sophgo" folder, that's why I think 
"sophgo" is redundant for file name.

Anyway, if you do WANT the format, I won't object strongly.

>
> Regards,
> Inochi