linux-kernel - RE: [PATCH v2 05/12] iommu/vt-d: Move PRI enablement in probe path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB527693E12F3AE890697C00608CC32@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Tue, 25 Feb 2025 07:37:53 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Lu Baolu <baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>, "Will
 Deacon" <will@...nel.org>, Robin Murphy <robin.murphy@....com>, "Jason
 Gunthorpe" <jgg@...pe.ca>
CC: "Jiang, Dave" <dave.jiang@...el.com>, Vinod Koul <vkoul@...nel.org>,
	Fenghua Yu <fenghuay@...dia.com>, Zhangfei Gao <zhangfei.gao@...aro.org>,
	Zhou Wang <wangzhou1@...ilicon.com>, "iommu@...ts.linux.dev"
	<iommu@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 05/12] iommu/vt-d: Move PRI enablement in probe path

> From: Lu Baolu <baolu.lu@...ux.intel.com>
> Sent: Monday, February 24, 2025 1:16 PM
>
> @@ -3743,6 +3743,16 @@ static struct iommu_device
> *intel_iommu_probe_device(struct device *dev)
>  			else
>  				info->ats_enabled = 1;
>  		}
> +
> +		if (info->ats_enabled && info->pri_supported) {
> +			/* PASID is required in PRG Response Message. */
> +			if (info->pasid_enabled
> || !pci_prg_resp_pasid_required(pdev)) {

this should be:

	if (!info->pasid_enabled || pci_prg_resp_pasid_required(pdev))


> @@ -3761,6 +3771,13 @@ static void intel_iommu_release_device(struct
> device *dev)
>  	struct device_domain_info *info = dev_iommu_priv_get(dev);
>  	struct intel_iommu *iommu = info->iommu;
> 
> +	WARN_ON(info->iopf_refcount);

call iopf_queue_remove_device() in this case?

> +void intel_iommu_disable_iopf(struct device *dev)
> +{
> +	struct device_domain_info *info = dev_iommu_priv_get(dev);
> +	struct intel_iommu *iommu = info->iommu;
> +
> +	if (WARN_ON(!info->pri_enabled))
> +		return;

also warn on !info->iopf_refcount