linux-kernel - Re: [PATCH v3 1/3] scsi: hisi_sas: Enable force phy when SATA disk directly connected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <420fde94-28ec-4321-943b-5cb84cf14f0e@oracle.com>
Date: Tue, 25 Feb 2025 08:19:01 +0000
From: John Garry <john.g.garry@...cle.com>
To: yangxingui <yangxingui@...wei.com>, liyihang9@...wei.com,
        yanaijie@...wei.com
Cc: jejb@...ux.ibm.com, martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        prime.zeng@...wei.com, liuyonglong@...wei.com, kangfenglong@...wei.com,
        liyangyang20@...wei.com, f.fangjian@...wei.com,
        xiabing14@...artners.com
Subject: Re: [PATCH v3 1/3] scsi: hisi_sas: Enable force phy when SATA disk
 directly connected

On 25/02/2025 01:48, yangxingui wrote:
>>
>>
>> pm8001 sends sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR,) 
>> link reset errors - can you consider doing that in 
>> hisi_sas_update_port_id() when you find an inconstant port id?
> Currently during phyup, the hw port id may change, and the corresponding 
> hisi_sas_port.id and the port id in itct are not updated synchronously. 
> The problem caused is not a link error, so we don't need deform port, 
> just update the port id when phyup.

Sure, but I am just trying to keep this simple. If you deform and reform 
the port - and so lose and find the disk (which does the itct config) - 
will that solve the problem?