linux-kernel - Re: [PATCH v3 1/3] scsi: hisi_sas: Enable force phy when SATA disk directly connected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4b7ae14-5b60-883a-c4f8-be11fc51a4f7@huawei.com>
Date: Tue, 25 Feb 2025 17:35:22 +0800
From: yangxingui <yangxingui@...wei.com>
To: John Garry <john.g.garry@...cle.com>, <liyihang9@...wei.com>,
	<yanaijie@...wei.com>
CC: <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linuxarm@...wei.com>, <prime.zeng@...wei.com>, <liuyonglong@...wei.com>,
	<kangfenglong@...wei.com>, <liyangyang20@...wei.com>,
	<f.fangjian@...wei.com>, <xiabing14@...artners.com>
Subject: Re: [PATCH v3 1/3] scsi: hisi_sas: Enable force phy when SATA disk
 directly connected

Hi, John

On 2025/2/25 16:19, John Garry wrote:
> On 25/02/2025 01:48, yangxingui wrote:
>>>
>>>
>>> pm8001 sends sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR,) 
>>> link reset errors - can you consider doing that in 
>>> hisi_sas_update_port_id() when you find an inconstant port id?
>> Currently during phyup, the hw port id may change, and the 
>> corresponding hisi_sas_port.id and the port id in itct are not updated 
>> synchronously. The problem caused is not a link error, so we don't 
>> need deform port, just update the port id when phyup.
> 
> Sure, but I am just trying to keep this simple. If you deform and reform 
> the port - and so lose and find the disk (which does the itct config) - 
> will that solve the problem?

1、phyup ->form port -> eh -> ata reset -> found hw port change -> 
deform port -> let dev gone -> refound

2、controller reset -> phyup -> finish controller reset -> found hw port 
change -> deform port -> let dev gone -> refound

I also thought about the plan you mentioned in the early days. The above 
will make the process more complicated and retriggering phyup may result 
in a new round of port id changes. Lose and find the disk will cause the 
upper layer IO to report error when controller reset. It seems that it 
is better to make the upper layer unaware of the hw port id change when 
phyup in reset, like ata reset or controller reset. ^_^

Thanks,
Xingui