linux-kernel - Re: [PATCH] mm/page_alloc: Clarify some migratetype fallback code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae808959-1ade-4989-81d9-026dc2722242@suse.cz>
Date: Tue, 25 Feb 2025 09:40:20 +0100
From: Vlastimil Babka <vbabka@...e.cz>
To: Brendan Jackman <jackmanb@...gle.com>
Cc: Johannes Weiner <hannes@...xchg.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Mel Gorman <mgorman@...hsingularity.net>, Michal Hocko <mhocko@...nel.org>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 Yosry Ahmed <yosry.ahmed@...ux.dev>
Subject: Re: [PATCH] mm/page_alloc: Clarify some migratetype fallback code

On 2/24/25 13:35, Brendan Jackman wrote:
> On Tue, 18 Feb 2025 at 11:20, Vlastimil Babka <vbabka@...e.cz> wrote:
>> Would it make sense to have only "bool *whole_block" parameter of
>> find_suitable_fallback? The value the caller initializes it, it means the
>> current need_whole_block, the value it has upon return it instructs the
>> caller what to do. It would mean __compact_finished() would no longer pass
>> an unused parameter.
> 
> I thought I liked this idea but once I tried it out I changed my mind

Right, me too actually.

> - the unused parameter is a bit of noise, but doing the above makes
> the function interface and implementation harder to understand.
> 
> I also thought of allowing the caller to specify NULL which would have
> the current meaning of only_steal=true, but again I don't think it's
> worth it.
> 
> So I'll skip this for v2 but we can always extend it later. I think
> it's likely that I'll end up proposing some other change to this
> interface for ASI anyway, let's see.

Ack.