linux-kernel - Re: [PATCH v3 net-next 4/6] net: hibmcge: Add support for mac link exception handling feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53672c20-82d1-4efa-8192-1c1d3ce15c1c@huawei.com>
Date: Tue, 25 Feb 2025 16:37:57 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>,
	<shenjian15@...wei.com>, <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
	<chenhao418@...wei.com>, <sudongming1@...wei.com>, <xujunsheng@...wei.com>,
	<shiyongbang@...wei.com>, <libaihan@...wei.com>,
	<jonathan.cameron@...wei.com>, <shameerali.kolothum.thodi@...wei.com>,
	<salil.mehta@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [PATCH v3 net-next 4/6] net: hibmcge: Add support for mac link
 exception handling feature


on 2025/2/25 11:09, Jakub Kicinski wrote:
> On Fri, 21 Feb 2025 19:55:24 +0800 Jijie Shao wrote:
>> +	if (!(priv->stats.np_link_fail_cnt % HBG_NP_LINK_FAIL_RETRY_TIMES)) {
> This adds a 64b divide which breaks the build on some 32b arches:
>
> ERROR: modpost: "__umoddi3" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined!

Okay, I'll fix this in the next version.

Thanks
Jijie Shao