linux-kernel - Re: [PATCH v3 net-next 2/6] net: hibmcge: Add support for rx checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <641ddf73-3497-433b-baf4-f7189384d19b@huawei.com>
Date: Tue, 25 Feb 2025 17:00:45 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>,
	<shenjian15@...wei.com>, <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
	<chenhao418@...wei.com>, <sudongming1@...wei.com>, <xujunsheng@...wei.com>,
	<shiyongbang@...wei.com>, <libaihan@...wei.com>,
	<jonathan.cameron@...wei.com>, <shameerali.kolothum.thodi@...wei.com>,
	<salil.mehta@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [PATCH v3 net-next 2/6] net: hibmcge: Add support for rx checksum
 offload

on 2025/2/25 11:09, Jakub Kicinski wrote:
> On Fri, 21 Feb 2025 19:55:22 +0800 Jijie Shao wrote:
>> +#define HBG_SUPPORT_FEATURES (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | \
> these are tx not rx

Yes, the processing of the driver tx checksum is received along with the xmit() function, and here it's just set features.
I may need to explain this in the commit log.

>
>> +			     NETIF_F_RXCSUM)
> I don't see you setting the checksum to anything other than NONE

When receiving packets, MAC checks the checksum by default. This behavior cannot be disabled.
If the checksum is incorrect, the MAC notifies the driver through the descriptor.

If checksum offload is enabled, the driver drops the packet.
Otherwise, the driver set the checksum to NONE and sends the packet to the stack.

Thanks,
Jijie Shao