linux-kernel - Re: [PATCH 05/12] badblocks: return error if any badblock set fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9fee454-54e0-d07f-44eb-74bfc588abeb@huaweicloud.com>
Date: Tue, 25 Feb 2025 17:12:11 +0800
From: Li Nan <linan666@...weicloud.com>
To: Coly Li <colyli@...nel.org>, Yu Kuai <yukuai1@...weicloud.com>
Cc: Coly Li <i@...y.li>, Zheng Qixing <zhengqixing@...weicloud.com>,
 axboe@...nel.dk, song@...nel.org, dan.j.williams@...el.com,
 vishal.l.verma@...el.com, dave.jiang@...el.com, ira.weiny@...el.com,
 dlemoal@...nel.org, yanjun.zhu@...ux.dev, kch@...dia.com,
 Hannes Reinecke <hare@...e.de>, zhengqixing@...wei.com,
 john.g.garry@...cle.com, geliang@...nel.org, xni@...hat.com, colyli@...e.de,
 linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-raid@...r.kernel.org, nvdimm@...ts.linux.dev, yi.zhang@...wei.com,
 yangerkun@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH 05/12] badblocks: return error if any badblock set fails



在 2025/2/22 14:16, Coly Li 写道:
> On Sat, Feb 22, 2025 at 09:12:53AM +0800, Yu Kuai wrote:
>> Hi,
>>
>> 在 2025/02/21 18:12, Coly Li 写道:
>>> So we don’t need to add a negative return value for partial success/failure?
>>>
>>> Coly Li.
>>
>> Yes, I think so. No one really use this value, and patch 10 clean this
>> up by changing return type to bool.
> 
> OK, then it is fine to me.
> 
> It will be good to add a code comment that parital setting will be treated as failure.
> 
> Thanks.
> 
> 

Thank you for your review. I will add comment in the next version.

-- 
Thanks,
Nan