linux-kernel - Re: [PATCH v4 5/5] i3c: master: svc: Fix npcm845 DAA process corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29a06fff-1fa2-49bd-aa72-e1eff1634b84@web.de>
Date: Tue, 25 Feb 2025 10:43:38 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Stanley Chu <yschu@...oton.com>, linux-i3c@...ts.infradead.org,
 devicetree@...r.kernel.org, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Conor Dooley <conor+dt@...nel.org>,
 Frank Li <Frank.Li@....com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>, Rob Herring <robh@...nel.org>
Cc: Stanley Chu <stanley.chuys@...il.com>, LKML
 <linux-kernel@...r.kernel.org>, Joseph Liu <KWLIU@...oton.com>,
 Tomer Maimon <tomer.maimon@...oton.com>
Subject: Re: [PATCH v4 5/5] i3c: master: svc: Fix npcm845 DAA process
 corruption

…
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1162,7 +1162,16 @@ static int svc_i3c_master_do_daa(struct i3c_master_controller *m)
>  	}
>
>  	spin_lock_irqsave(&master->xferqueue.lock, flags);
…
>  	spin_unlock_irqrestore(&master->xferqueue.lock, flags);
>
>  	svc_i3c_master_clear_merrwarn(master);
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&master->xferqueue.lock);”?
https://elixir.bootlin.com/linux/v6.14-rc4/source/include/linux/spinlock.h#L572

Regards,
Markus