linux-kernel - Re: [PATCH 1/2] rust: Add cpumask helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9E7A81AA-6460-4F87-942E-2EEA145257F2@collabora.com>
Date: Tue, 25 Feb 2025 06:43:31 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Yury Norov <yury.norov@...il.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
 Viresh Kumar <viresh.kumar@...aro.org>,
 Danilo Krummrich <dakr@...hat.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Rasmus Villemoes <linux@...musvillemoes.dk>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Stephen Boyd <sboyd@...nel.org>,
 Nishanth Menon <nm@...com>,
 Manos Pitsidianakis <manos.pitsidianakis@...aro.org>,
 Erik Schilling <erik.schilling@...aro.org>,
 Alex Bennée <alex.bennee@...aro.org>,
 Joakim Bech <joakim.bech@...aro.org>,
 Rob Herring <robh@...nel.org>,
 Christoph Hellwig <hch@....de>,
 Jason Gunthorpe <jgg@...dia.com>,
 John Hubbard <jhubbard@...dia.com>,
 linux-pm@...r.kernel.org,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] rust: Add cpumask helpers

Hi Yury,

> On 24 Feb 2025, at 20:39, Yury Norov <yury.norov@...il.com> wrote:
> 
> From: Viresh Kumar <viresh.kumar@...aro.org>
> 
> In order to prepare for adding Rust abstractions for cpumask, add
> the required helpers for inline cpumask functions that cannot be
> called by rust code directly.

I don’t understand what is going on here. You apparently did not provide the
Rust code itself.

Usually, when I see a “in order to prepare for …” I expect the actual patch to
follow in the same series.

Right now - and correct me if I'm wrong - it seems like you’ve essentially added
dead code.

— Daniel