linux-kernel - Re: [PATCH v4 2/3] irqchip: Add the Sophgo SG2042 MSI interrupt controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PN0PR01MB9166295EEDDDD734F00BF4A1FEC22@PN0PR01MB9166.INDPRD01.PROD.OUTLOOK.COM>
Date: Wed, 26 Feb 2025 09:37:44 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Inochi Amaoto <inochiama@...il.com>
Cc: Chen Wang <unicornxw@...il.com>, u.kleine-koenig@...libre.com,
 aou@...s.berkeley.edu, arnd@...db.de, conor+dt@...nel.org,
 guoren@...nel.org, inochiama@...look.com, krzk+dt@...nel.org,
 palmer@...belt.com, paul.walmsley@...ive.com, robh@...nel.org,
 tglx@...utronix.de, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 chao.wei@...hgo.com, xiaoguang.xing@...hgo.com, fengchun.li@...hgo.com
Subject: Re: [PATCH v4 2/3] irqchip: Add the Sophgo SG2042 MSI interrupt
 controller


On 2025/2/21 14:35, Inochi Amaoto wrote:
[......]
>> +static int sg2042_msi_init_domains(struct sg2042_msi_chipdata *data,
>> +				   struct device *dev)
>> +{
>> +	struct fwnode_handle *fwnode = dev_fwnode(dev);
>> +	struct irq_domain *plic_domain, *middle_domain;
>> +	struct fwnode_handle *plic_node;
>> +
>> +	plic_node = fwnode_find_reference(fwnode, "msi-ranges", 0);
>> +	if (IS_ERR(plic_node)) {
>> +		pr_err("Failed to find the PLIC node!\n");
>> +		return PTR_ERR(plic_node);
>> +	}
> I think plic_node is just the args.fwnode in the sg2042_msi_probe.
> Just reuse it. No need to parse this again.
>
> Otherwise, It looks good to me. With this fix:
>
> Reviewed-by: Inochi Amaoto <inochiama@...il.com>

Thanks, I will fix this.

Regards,

Chen

[......]