linux-kernel - Re: [PATCH 1/2] rust/faux: Drop #[repr(transparent)] from faux::Registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2bjuolv3k.fsf@kloenk.dev>
Date: Wed, 26 Feb 2025 13:59:59 +0100
From: Fiona Behrens <me@...enk.dev>
To: Lyude Paul <lyude@...hat.com>
Cc: rust-for-linux@...r.kernel.org,  Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>,  Maíra Canal
 <mairacanal@...eup.net>,
  "Rafael J. Wysocki" <rafael@...nel.org>,  Danilo Krummrich
 <dakr@...nel.org>,  Miguel Ojeda <ojeda@...nel.org>,  Alex Gaynor
 <alex.gaynor@...il.com>,  Boqun Feng <boqun.feng@...il.com>,  Gary Guo
 <gary@...yguo.net>,  Björn Roy Baron
 <bjorn3_gh@...tonmail.com>,  Benno
 Lossin <benno.lossin@...ton.me>,  Andreas Hindborg
 <a.hindborg@...nel.org>,  Alice Ryhl <aliceryhl@...gle.com>,  Trevor Gross
 <tmgross@...ch.edu>,  linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH 1/2] rust/faux: Drop #[repr(transparent)] from
 faux::Registration

Lyude Paul <lyude@...hat.com> writes:

> I think this change got missed during review, we don't need
>  #[repr(transparent)] since Registration just holds a single NonNull. This
> attribute had originally been added by me when I was still figuring out how
> the bindings should look like but got committed by mistake. So, just drop
> it.
>
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Reviewed-by: Fiona Behrens <me@...enk.dev>

> ---
>  rust/kernel/faux.rs | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/rust/kernel/faux.rs b/rust/kernel/faux.rs
> index 5acc0c02d451f..41751403cd868 100644
> --- a/rust/kernel/faux.rs
> +++ b/rust/kernel/faux.rs
> @@ -19,7 +19,6 @@
>  /// `self.0` always holds a valid pointer to an initialized and registered [`struct faux_device`].
>  ///
>  /// [`struct faux_device`]: srctree/include/linux/device/faux.h
> -#[repr(transparent)]
>  pub struct Registration(NonNull<bindings::faux_device>);
>  
>  impl Registration {