linux-kernel - Re: [PATCH 1/2] rust/faux: Drop #[repr(transparent)] from faux::Registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH5fLgiku4K9n4p4WaFJWD_GgaOjHND+UW2Bnf3FL8A6M76DFw@mail.gmail.com>
Date: Wed, 26 Feb 2025 09:39:17 +0100
From: Alice Ryhl <aliceryhl@...gle.com>
To: Lyude Paul <lyude@...hat.com>
Cc: rust-for-linux@...r.kernel.org, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Maíra Canal <mairacanal@...eup.net>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Danilo Krummrich <dakr@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] rust/faux: Drop #[repr(transparent)] from faux::Registration

On Tue, Feb 25, 2025 at 10:31 PM Lyude Paul <lyude@...hat.com> wrote:
>
> I think this change got missed during review, we don't need
>  #[repr(transparent)] since Registration just holds a single NonNull. This
> attribute had originally been added by me when I was still figuring out how
> the bindings should look like but got committed by mistake. So, just drop
> it.
>
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>