linux-kernel - Re: [PATCH v1 6/9] dt-bindings: memory: Document Tegra114 External Memory Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPVz0n2rOuskKRTbmoFUJQb6ZFJ_nDESJMNE_iio=EsHWqZ4Og@mail.gmail.com>
Date: Wed, 26 Feb 2025 17:28:05 +0200
From: Svyatoslav Ryhel <clamor95@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, 
	Peter De Schrijver <pdeschrijver@...dia.com>, Prashant Gaikwad <pgaikwad@...dia.com>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Jonathan Cameron <Jonathan.Cameron@...wei.com>, Georgi Djakov <djakov@...nel.org>, 
	Dmitry Osipenko <digetx@...il.com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-tegra@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v1 6/9] dt-bindings: memory: Document Tegra114 External
 Memory Controller

ср, 26 лют. 2025 р. о 17:15 Rob Herring <robh@...nel.org> пише:
>
> On Tue, Feb 25, 2025 at 04:34:58PM +0200, Svyatoslav Ryhel wrote:
> > Document External Memory Controller found in the Tegra 4 SoC.
>
> This all looks very close to tegra124. Could have missed something, but
> I see 1 property difference and 'nvidia,emc-configuration' is slightly
> different. I'd just add tegra114 to the existing schema. For
> 'nvidia,emc-configuration', I would just list the range for the length.
> It's just a list of magic register values, so we can't really do any
> validation of it. And I don't care what register is which entry. If you
> really want to document that, then keep the existing list and put 0
> value entries for any registers that don't exist on tegra114 and put new
> registers on the end of the list.
>

You are totally correct, my first intention was to reuse tegra124
schema, but I did not knew how to handle the timing list correctly.
Tegra114 version does not have one of the entries in that list. I have
tried to use condition to define additional entry but yaml check
continued to complain. Maybe you can show an example where similar
situation is resolved? Thank you.

> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
> > ---
> >  .../nvidia,tegra114-emc.yaml                  | 431 ++++++++++++++++++
> >  1 file changed, 431 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-emc.yaml