linux-kernel - Re: [PATCH v1 0/9] Tegra114: implement EMC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <174058435857.2478604.15934788005971294558.robh@kernel.org>
Date: Wed, 26 Feb 2025 09:42:06 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Svyatoslav Ryhel <clamor95@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, 
 Peter De Schrijver <pdeschrijver@...dia.com>, linux-kernel@...r.kernel.org, 
 linux-clk@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
 Georgi Djakov <djakov@...nel.org>, Stephen Boyd <sboyd@...nel.org>, 
 Thierry Reding <thierry.reding@...il.com>, 
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, linux-tegra@...r.kernel.org, 
 Michael Turquette <mturquette@...libre.com>, devicetree@...r.kernel.org, 
 Prashant Gaikwad <pgaikwad@...dia.com>, 
 Jonathan Hunter <jonathanh@...dia.com>, Dmitry Osipenko <digetx@...il.com>
Subject: Re: [PATCH v1 0/9] Tegra114: implement EMC support


On Tue, 25 Feb 2025 16:34:52 +0200, Svyatoslav Ryhel wrote:
> Add support for External Memory Controller found in Tegra 4 SoC along
> with adjustments required for it to work properly.
> 
> Tested on ASUS TF701T (T40X) and Nvidia Tegratab (T40S). Both work fine.
> 
> Svyatoslav Ryhel (9):
>   ARM: tegra: Add ACTMON support on Tegra114
>   dt-bindings: memory: Document Tegra114 Memory Controller
>   drivers: memory: tegra: implement EMEM regs and ICC ops for T114
>   dt-bindings: memory: tegra114: Add memory client IDs
>   clk: tegra114: remove emc to mc clock mux
>   dt-bindings: memory: Document Tegra114 External Memory Controller
>   memory: tegra: Add Tegra114 EMC driver
>   ARM: tegra: Add External Memory Controller node on Tegra114
>   ARM: tegra: Add EMC OPP and ICC properties to Tegra114 EMC and ACTMON
>     device-tree nodes
> 
>  .../nvidia,tegra114-emc.yaml                  |  431 +++++
>  .../nvidia,tegra114-mc.yaml                   |  154 ++
>  .../dts/nvidia/tegra114-peripherals-opp.dtsi  |  151 ++
>  arch/arm/boot/dts/nvidia/tegra114.dtsi        |   32 +
>  drivers/clk/tegra/clk-tegra114.c              |   48 +-
>  drivers/memory/tegra/Kconfig                  |   12 +
>  drivers/memory/tegra/Makefile                 |    1 +
>  drivers/memory/tegra/tegra114-emc.c           | 1487 +++++++++++++++++
>  drivers/memory/tegra/tegra114.c               |  193 +++
>  include/dt-bindings/memory/tegra114-mc.h      |   67 +
>  10 files changed, 2561 insertions(+), 15 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-emc.yaml
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-mc.yaml
>  create mode 100644 arch/arm/boot/dts/nvidia/tegra114-peripherals-opp.dtsi
>  create mode 100644 drivers/memory/tegra/tegra114-emc.c
> 
> --
> 2.43.0
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/nvidia/' for 20250225143501.68966-1-clamor95@...il.com:

arch/arm/boot/dts/nvidia/tegra114-tn7.dtb: clock@...06000: 'nvidia,external-memory-controller' does not match any of the regexes: '^(sclk)|(pll-[cem])$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/clock/nvidia,tegra20-car.yaml#
arch/arm/boot/dts/nvidia/tegra114-tn7.dtb: actmon@...0c800: compatible: ['nvidia,tegra114-actmon', 'nvidia,tegra124-actmon'] is too long
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-tn7.dtb: actmon@...0c800: '#cooling-cells' is a required property
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-roth.dtb: clock@...06000: 'nvidia,external-memory-controller' does not match any of the regexes: '^(sclk)|(pll-[cem])$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/clock/nvidia,tegra20-car.yaml#
arch/arm/boot/dts/nvidia/tegra114-roth.dtb: actmon@...0c800: compatible: ['nvidia,tegra114-actmon', 'nvidia,tegra124-actmon'] is too long
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-roth.dtb: actmon@...0c800: '#cooling-cells' is a required property
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-dalmore.dtb: clock@...06000: 'nvidia,external-memory-controller' does not match any of the regexes: '^(sclk)|(pll-[cem])$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/clock/nvidia,tegra20-car.yaml#
arch/arm/boot/dts/nvidia/tegra114-dalmore.dtb: actmon@...0c800: compatible: ['nvidia,tegra114-actmon', 'nvidia,tegra124-actmon'] is too long
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-dalmore.dtb: actmon@...0c800: '#cooling-cells' is a required property
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dtb: clock@...06000: 'nvidia,external-memory-controller' does not match any of the regexes: '^(sclk)|(pll-[cem])$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/clock/nvidia,tegra20-car.yaml#
arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dtb: actmon@...0c800: compatible: ['nvidia,tegra114-actmon', 'nvidia,tegra124-actmon'] is too long
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dtb: actmon@...0c800: '#cooling-cells' is a required property
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dtb: bluetooth: reset-gpios: False schema does not allow [[22, 134, 1]]
	from schema $id: http://devicetree.org/schemas/net/bluetooth/brcm,bluetooth.yaml#