linux-kernel - Re: [PATCH v1 0/2] leds: add new LED driver for TI LP5812

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174058435900.2478640.10516296167276043499.robh@kernel.org>
Date: Wed, 26 Feb 2025 09:42:08 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Nam Tran <trannamatk@...il.com>
Cc: linux-leds@...r.kernel.org, devicetree@...r.kernel.org, 
 linux-kernel@...r.kernel.org, pavel@...nel.org, conor+dt@...nel.org, 
 lee@...nel.org, krzk+dt@...nel.org
Subject: Re: [PATCH v1 0/2] leds: add new LED driver for TI LP5812


On Wed, 26 Feb 2025 00:05:59 +0700, Nam Tran wrote:
> From: Nam Tran <trannamatk@...il.com>
> To: Pavel Machek <pavel@...nel.org>, Lee Jones <lee@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>
> Cc: linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
> 
> This patch series adds support for the Texas Instruments LP5812 LED driver.
> Patch 1 adds the Device Tree (DT) bindings documentation.
> Patch 2 introduces the core driver implementation.
> 
> The LP5812 is an I2C-controlled LED driver capable of driving up to 4 LEDs with independent brightness control and pattern programming.
> This driver provides support through the Linux LED framework and includes device tree bindings for proper integration.
> 
> This driver has been tested on Raspberry Pi 4 B using kernel version 6.14.0.
> 
> I kindly request feedback from the community to ensure that this driver adheres to the Linux LED subsystem standards.
> 
> Thank you for your consideration.
> 
> Best regards,
> Nam
> 
> ---
> 
> Changes in v2:
> - Renamed DT bindings file from `leds-lp5812.yaml` to `ti,lp5812.yaml`.
> - Added LP5812 device tree node to `bcm2711-rpi-4b.dts` for Raspberry Pi 4B.
> - Updated core driver implementation to fix build errors in kernel version 6.14.0-rc4. (The v1 patch was only compatible with kernel version 6.1.93)
> 
> Signed-off-by: Nam Tran <trannamatk@...il.com>
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/broadcom/' for 20250225170601.21334-1-trannamatk@...il.com:

arch/arm/boot/dts/broadcom/bcm2711-rpi-400.dtb: /soc/i2c@...04000/lp5812@1b: failed to match any schema with compatible: ['ti,lp5812']
arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dtb: /soc/i2c@...04000/lp5812@1b: failed to match any schema with compatible: ['ti,lp5812']