linux-kernel - Re: [PATCH 5/8] tracing: probe-events: Remove unused MAX_ARG_BUF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250226103247.23abdd62@gandalf.local.home>
Date: Wed, 26 Feb 2025 10:32:47 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: Shuah Khan <shuah@...nel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Hari Bathini <hbathini@...ux.ibm.com>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 5/8] tracing: probe-events: Remove unused
 MAX_ARG_BUF_LEN macro

On Wed, 26 Feb 2025 15:19:18 +0900
"Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:

> From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> 
> Commit 18b1e870a496 ("tracing/probes: Add $arg* meta argument for all
> function args") introduced MAX_ARG_BUF_LEN but it is not used.
> Remove it.
> 
> Fixes: 18b1e870a496 ("tracing/probes: Add $arg* meta argument for all function args")
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> ---

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve


>  kernel/trace/trace_probe.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h
> index 6075afc8ea67..854e5668f5ee 100644
> --- a/kernel/trace/trace_probe.h
> +++ b/kernel/trace/trace_probe.h
> @@ -36,7 +36,6 @@
>  #define MAX_BTF_ARGS_LEN	128
>  #define MAX_DENTRY_ARGS_LEN	256
>  #define MAX_STRING_SIZE		PATH_MAX
> -#define MAX_ARG_BUF_LEN		(MAX_TRACE_ARGS * MAX_ARG_NAME_LEN)
>  
>  /* Reserved field names */
>  #define FIELD_STRING_IP		"__probe_ip"