linux-kernel - Re: [PATCH 2/8] tracing: tprobe-events: Reject invalid tracepoint name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4f9a423-6c47-42ea-a6c8-6954a9b5ca2e@web.de>
Date: Wed, 26 Feb 2025 16:50:39 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Masami Hiramatsu <mhiramat@...nel.org>,
 linux-trace-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Shuah Khan <shuah@...nel.org>, Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Hari Bathini
 <hbathini@...ux.ibm.com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH 2/8] tracing: tprobe-events: Reject invalid tracepoint
 name

…
> +++ b/kernel/trace/trace_fprobe.c
> @@ -1049,6 +1049,19 @@ static int parse_symbol_and_return(int argc, const char *argv[],
>  	if (*is_return)
>  		return 0;
>
> +	if (is_tracepoint) {
…
> +			kfree(*symbol);
> +			*symbol = NULL;
> +			return -EINVAL;
> +		}
> +	}
…

May a bit of exception handling code be shared by an additional jump target?
Will another goto chain become helpful here?

Regards,
Markus