linux-kernel - Re: [PATCH 4/8] tracing: probe-events: Log errro for exceeding the number of arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <516ea911-acc6-47c2-87d5-2df0a18468de@web.de>
Date: Wed, 26 Feb 2025 17:13:17 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Masami Hiramatsu <mhiramat@...nel.org>,
 linux-trace-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Shuah Khan <shuah@...nel.org>, Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Hari Bathini
 <hbathini@...ux.ibm.com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH 4/8] tracing: probe-events: Log errro for exceeding the
 number of arguments

…
> +++ b/kernel/trace/trace_fprobe.c
> @@ -1201,8 +1201,11 @@ static int trace_fprobe_create_internal(int argc, const char *argv[],
>  		argc = new_argc;
>  		argv = new_argv;
>  	}
> -	if (argc > MAX_TRACE_ARGS)
> +	if (argc > MAX_TRACE_ARGS) {
> +		trace_probe_log_set_index(2);
> +		trace_probe_log_err(0, TOO_MANY_ARGS);
>  		return -E2BIG;
> +	}
>
>  	ret = traceprobe_expand_dentry_args(argc, argv, &dbuf);
…

May a bit of exception handling code be shared by an additional jump target?
Will another goto chain become helpful here?


How do you think about to avoid a typo in the summary phrase?

Regards,
Markus