linux-kernel - Re: [PATCH 1/2] dt-bindings: reset: syscon-reboot: support reset modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c013c053b8677ee6bb2a37bc48e90a25fa16d7e.camel@linaro.org>
Date: Wed, 26 Feb 2025 16:20:27 +0000
From: André Draszik <andre.draszik@...aro.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, devicetree@...r.kernel.org, 
	linux-pm@...r.kernel.org, Peter Griffin <peter.griffin@...aro.org>, Conor
 Dooley	 <conor+dt@...nel.org>, Will McVicker <willmcvicker@...gle.com>, 
	linux-kernel@...r.kernel.org, kernel-team@...roid.com, Krzysztof Kozlowski	
 <krzk+dt@...nel.org>, Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: reset: syscon-reboot: support reset
 modes

On Wed, 2025-02-26 at 15:42 +0000, André Draszik wrote:
> On Wed, 2025-02-26 at 09:29 -0600, Rob Herring (Arm) wrote:
> > 
> > On Wed, 26 Feb 2025 14:08:20 +0000, André Draszik wrote:
> > > Add support for specifying different register/mask/value combinations
> > > for different types of reset.
> > > 
> > > In particular, update the binding to allow platforms to specify the
> > > following reset modes: soft, warm, cold, hard.
> > > 
> > > Linux can perform different types of reset using its reboot= kernel
> > > command line argument, and some platforms also wish to reset
> > > differently based on whether or not e.g. contents of RAM should be
> > > retained across the reboot.
> > > 
> > > The new properties match the existing properties, just prefixed with
> > > one of the reset modes mentioned above.
> > > 
> > > Signed-off-by: André Draszik <andre.draszik@...aro.org>
> > > ---
> > >  .../bindings/power/reset/syscon-reboot.yaml        | 74 ++++++++++++++++++++++
> > >  1 file changed, 74 insertions(+)
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> 
> oops, sorry - the script we usually run didn't cover this binding,

BTW, we did that, because it's easy to miss warnings due to
the amount of bindings and text scrolling past. Ideally make
would exit with != 0 in case of binding errors.

I can see in commit 3e95dfb315de ("dt-bindings: Don't error
out on yamllint and dt-doc-validate errors"), warnings are
never treated as errors.

Is that still relevant, can that commit be revert? Don't we
want the build to fail loudly on binding errors, so that people
don't even submit erroneous bindings in the first place?

Cheers,
Andre'