linux-kernel - Re: [PATCH v4 09/10] dt-bindings: PCI: qcom,pcie-sc7280: Add 'global' interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e83bc594-5500-4f76-b3d1-96f669515c24@kernel.org>
Date: Wed, 26 Feb 2025 22:33:05 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bjorn Andersson <andersson@...nel.org>
Cc: Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 chaitanya chundru <quic_krichai@...cinc.com>,
 Konrad Dybcio <konradybcio@...nel.org>, cros-qcom-dts-watchers@...omium.org,
 Jingoo Han <jingoohan1@...il.com>, Bartosz Golaszewski <brgl@...ev.pl>,
 quic_vbadigan@...cnic.com, amitk@...nel.org, dmitry.baryshkov@...aro.org,
 linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 jorge.ramirez@....qualcomm.com
Subject: Re: [PATCH v4 09/10] dt-bindings: PCI: qcom,pcie-sc7280: Add 'global'
 interrupt

On 26/02/2025 17:29, Bjorn Andersson wrote:
>>> @@ -54,7 +54,7 @@ properties:
>>>  
>>>    interrupts:
>>>      minItems: 8
>>> -    maxItems: 8
>>> +    maxItems: 9
>>>  
>>>    interrupt-names:
>>>      items:
>>> @@ -66,6 +66,7 @@ properties:
>>>        - const: msi5
>>>        - const: msi6
>>>        - const: msi7
>>> +      - const: global
>>
>> Either context is missing or these are not synced with interrupts.
>>
> 
> I think the patch context ("properties") is confusing here, but it looks
> to me that these are in sync: interrupts is defined to have 8 items, and
> interrupt-names is a list of msi0 through msi7.

interrupt-names has minItems 9 in this case, so they are not synced.
That's my concern


Best regards,
Krzysztof