linux-kernel - Re: [PATCH 1/4] media: dt-bindings: Add Sony IMX728

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6db6b361-caed-42f4-b319-2b8cd43a73b5@linaro.org>
Date: Wed, 26 Feb 2025 22:38:54 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sebastian LaVine <slavine@...mbedded.com>
Cc: devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, Nícolas F. R. A. Prado
 <nfraprado@...labora.com>, Abel Vesa <abel.vesa@...aro.org>,
 Achath Vaishnav <vaishnav.a@...com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Ard Biesheuvel <ardb@...nel.org>,
 Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
 Biju Das <biju.das.jz@...renesas.com>,
 Bjorn Andersson <quic_bjorande@...cinc.com>,
 Catalin Marinas <catalin.marinas@....com>, Conor Dooley
 <conor+dt@...nel.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Elinor Montmasson <elinor.montmasson@...oirfairelinux.com>,
 Fabio Estevam <festevam@...il.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Hans Verkuil <hverkuil@...all.nl>,
 Javier Carrasco <javier.carrasco@...fvision.net>, Jianzhong Xu <xuj@...com>,
 Julien Massot <julien.massot@...labora.com>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Kory Maincent <kory.maincent@...tlin.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Mikhail Rudenko <mike.rudenko@...il.com>, Nishanth Menon <nm@...com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Rob Herring <robh@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Stuart Burtner <sburtner@...mbedded.com>, Tero Kristo <kristo@...nel.org>,
 Thakkar Devarsh <devarsht@...com>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
 Umang Jain <umang.jain@...asonboard.com>,
 Vignesh Raghavendra <vigneshr@...com>, Will Deacon <will@...nel.org>,
 Zhi Mao <zhi.mao@...iatek.com>
Subject: Re: [PATCH 1/4] media: dt-bindings: Add Sony IMX728

On 26/02/2025 18:50, Sebastian LaVine wrote:
> Hello Krzysztof,
> 
> On Thu Feb 13, 2025 at 4:26 AM EST, Krzysztof Kozlowski wrote:
>> On Wed, Feb 12, 2025 at 02:56:53PM -0500, Sebastian LaVine wrote:
>>> Adds bindings for the Sony IMX728.
>>>
>>> Signed-off-by: Sebastian LaVine <slavine@...mbedded.com>
>>> Mentored-by: Stuart Burtner <sburtner@...mbedded.com>
>>> ---
>>
>> Please run scripts/checkpatch.pl and fix reported warnings. After that,
>> run also 'scripts/checkpatch.pl --strict' and (probably) fix more
>> warnings. Some warnings can be ignored, especially from --strict run,
>> but the code here looks like it needs a fix. Feel free to get in touch
>> if the warning is not clear.
> 
> The only output I get from scripts/checkpatch.pl for this patch is the
> following:
> 
>> next$ scripts/checkpatch.pl --strict  patches/outgoing/0001-media-dt-bindings-Add-Sony-IMX728.patch
>> WARNING: Non-standard signature: Mentored-by:
>> #9:
>> Mentored-by: Stuart Burtner <sburtner@...mbedded.com>
>>
>> total: 0 errors, 1 warnings, 0 checks, 108 lines checked
>>
>> ...
> 
> I can change this to a Signed-off-by from Stuart if you would like,
> though I feel that Mentored-by is applicable to this case.

It has been two weeks, so I don't remember what warning I saw (countless
of patches in between). It's possible I had in mind the "mentored-by",
because it's nowhere explained in Linux. Does it mean part of DCO chain?
Does it mean reviews or suggestions? This should be one of standard
tags, IMO, with all its effects (because tags have meaning, e.g. DCO or
reviewer's statement of oversight).

Best regards,
Krzysztof