linux-kernel - Re: [PATCH 2/4] media: i2c: Add driver for Sony IMX728

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac6a461b-44f3-414e-b5a2-2d5a0a87cdf8@linaro.org>
Date: Wed, 26 Feb 2025 22:40:01 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sebastian LaVine <slavine@...mbedded.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Cc: Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Abel Vesa <abel.vesa@...aro.org>, Achath Vaishnav <vaishnav.a@...com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Ard Biesheuvel <ardb@...nel.org>,
 Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
 Biju Das <biju.das.jz@...renesas.com>,
 Bjorn Andersson <quic_bjorande@...cinc.com>,
 Catalin Marinas <catalin.marinas@....com>, Conor Dooley
 <conor+dt@...nel.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Elinor Montmasson <elinor.montmasson@...oirfairelinux.com>,
 Fabio Estevam <festevam@...il.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Hans Verkuil <hverkuil@...all.nl>,
 Javier Carrasco <javier.carrasco@...fvision.net>, Jianzhong Xu <xuj@...com>,
 Julien Massot <julien.massot@...labora.com>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Kory Maincent <kory.maincent@...tlin.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Mikhail Rudenko <mike.rudenko@...il.com>, Nishanth Menon <nm@...com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Rob Herring <robh@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Stuart Burtner <sburtner@...mbedded.com>, Tero Kristo <kristo@...nel.org>,
 Thakkar Devarsh <devarsht@...com>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
 Umang Jain <umang.jain@...asonboard.com>,
 Vignesh Raghavendra <vigneshr@...com>, Will Deacon <will@...nel.org>,
 Zhi Mao <zhi.mao@...iatek.com>
Subject: Re: [PATCH 2/4] media: i2c: Add driver for Sony IMX728

On 26/02/2025 21:13, Sebastian LaVine wrote:
>> ...
>>
>>> +
>>> +static int imx728_set_stream(struct v4l2_subdev *sd, int enable)
>>> +{
>>> +       struct imx728 *imx728 = to_imx728(sd);
>>> +       int ret;
>>> +
>>> +       mutex_lock(&imx728->lock);
>>
>> Just use guard. That's actually perfect candidate.
>>
> 
> Okay -- I'll include this change in v4. I'm not so familiar with using
> this interface, so please let me know if this is incorrect:
> 

Yes, looks fine.

Best regards,
Krzysztof