linux-kernel - Re: [PATCH v4 08/15] drm/tests: bridge: Provide tests for drm_bridge_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <gf36bwz5kpoetdnmwu4xfupxrxciojw3yebfylbwwwu4dhdxkf@6hh5sc5ts3pa>
Date: Wed, 26 Feb 2025 08:43:16 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Maxime Ripard <mripard@...nel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Andrzej Hajda <andrzej.hajda@...el.com>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>, 
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Douglas Anderson <dianders@...omium.org>, 
	Herve Codina <herve.codina@...tlin.com>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 08/15] drm/tests: bridge: Provide tests for
 drm_bridge_reset_crtc

On Tue, Feb 25, 2025 at 05:43:56PM +0100, Maxime Ripard wrote:
> Let's provide a bunch of kunit tests to make sure
> drm_bridge_reset_crtc() works as expected.
> 
> Signed-off-by: Maxime Ripard <mripard@...nel.org>
> ---
>  drivers/gpu/drm/tests/drm_bridge_test.c | 168 +++++++++++++++++++++++++++++++-
>  1 file changed, 167 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tests/drm_bridge_test.c b/drivers/gpu/drm/tests/drm_bridge_test.c
> index c0a05c459d957c3f9d281957f002f6bd36cce367..4bcc761b3ba70bfa0ccc56b0685e35f86bde63fd 100644
> --- a/drivers/gpu/drm/tests/drm_bridge_test.c
> +++ b/drivers/gpu/drm/tests/drm_bridge_test.c
> @@ -14,17 +14,57 @@ struct drm_bridge_init_priv {
>  	struct drm_plane *plane;
>  	struct drm_crtc *crtc;
>  	struct drm_encoder encoder;
>  	struct drm_bridge bridge;
>  	struct drm_connector *connector;
> +	unsigned int enable_count;
> +	unsigned int disable_count;
>  };
>  
> +static void drm_test_bridge_enable(struct drm_bridge *bridge)
> +{
> +	struct drm_bridge_init_priv *priv =
> +		container_of(bridge, struct drm_bridge_init_priv, bridge);
> +
> +	priv->enable_count++;
> +}
> +
> +static void drm_test_bridge_disable(struct drm_bridge *bridge)
> +{
> +	struct drm_bridge_init_priv *priv =
> +		container_of(bridge, struct drm_bridge_init_priv, bridge);
> +
> +	priv->disable_count++;
> +}
> +
>  static const struct drm_bridge_funcs drm_test_bridge_legacy_funcs = {
> +	.enable			= drm_test_bridge_enable,
> +	.disable		= drm_test_bridge_disable,
>  };
>  
> +static void drm_test_bridge_atomic_enable(struct drm_bridge *bridge,
> +					  struct drm_atomic_state *state)
> +{
> +	struct drm_bridge_init_priv *priv =
> +		container_of(bridge, struct drm_bridge_init_priv, bridge);
> +
> +	priv->enable_count++;
> +}
> +
> +static void drm_test_bridge_atomic_disable(struct drm_bridge *bridge,
> +					   struct drm_atomic_state *state)
> +{
> +	struct drm_bridge_init_priv *priv =
> +		container_of(bridge, struct drm_bridge_init_priv, bridge);
> +
> +	priv->disable_count++;
> +}
> +
>  static const struct drm_bridge_funcs drm_test_bridge_atomic_funcs = {
> +	.atomic_enable		= drm_test_bridge_atomic_enable,
>  	.atomic_destroy_state	= drm_atomic_helper_bridge_destroy_state,
> +	.atomic_disable		= drm_test_bridge_atomic_disable,

I think we usually use paired order rather than just ordering those
alphabetically. It makese sense to group .atomic_enable with
.atomic_disable.

Other than that:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>


>  	.atomic_duplicate_state	= drm_atomic_helper_bridge_duplicate_state,
>  	.atomic_reset		= drm_atomic_helper_bridge_reset,
>  };
>  
>  KUNIT_DEFINE_ACTION_WRAPPER(drm_bridge_remove_wrapper,

-- 
With best wishes
Dmitry