[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <33504452-6326-4403-95e1-fef40f3fb49e@kernel.org>
Date: Wed, 26 Feb 2025 08:05:29 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Peter Chen <peter.chen@...tech.com>, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, catalin.marinas@....com, will@...nel.org, arnd@...db.de
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, cix-kernel-upstream@...tech.com,
marcin@...zkiewicz.com.pl, Fugang Duan <fugang.duan@...tech.com>
Subject: Re: [PATCH v2 6/6] arm64: dts: cix: add initial CIX P1(SKY1) dts
support
On 26/02/2025 02:21, Peter Chen wrote:
> + core7 {
> + cpu = <&cpu7>;
> + };
> + core8 {
> + cpu = <&cpu8>;
> + };
> + core9 {
> + cpu = <&cpu9>;
> + };
> + core10 {
> + cpu = <&cpu10>;
> + };
> + core11 {
> + cpu = <&cpu11>;
> + };
> + };
> + };
> +
Stray blank line
> + };
> +
> + pmu-a520 {
> + compatible = "arm,cortex-a520-pmu";
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + pmu-a720 {
> + compatible = "arm,cortex-a720-pmu";
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + pmu-spe {
> + compatible = "arm,statistical-profiling-extension-v1";
> + interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + psci {
> + compatible = "arm,psci-1.0";
> + method = "smc";
> + };
> +
> + soc@0 {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges = <0 0 0 0 0x20 0>;
Ranges is like reg, so after compatible. See DTS coding style.
Best regards,
Krzysztof
Powered by blists - more mailing lists