linux-kernel - Re: [PATCH 2/2] rust/faux: Add missing parent argument to Registration::new()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025022609-hamper-paging-8761@gregkh>
Date: Wed, 26 Feb 2025 12:01:38 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Alice Ryhl <aliceryhl@...gle.com>, kernel@...r.org,
	a.hindborg@...nel.org, alex.gaynor@...il.com,
	benno.lossin@...ton.me, bjorn3_gh@...tonmail.com,
	boqun.feng@...il.com, gary@...yguo.net,
	linux-kernel@...r.kernel.org, lyude@...hat.com,
	mairacanal@...eup.net, ojeda@...nel.org, rafael@...nel.org,
	rust-for-linux@...r.kernel.org, tmgross@...ch.edu
Subject: Re: [PATCH 2/2] rust/faux: Add missing parent argument to
 Registration::new()

On Wed, Feb 26, 2025 at 11:39:31AM +0100, Danilo Krummrich wrote:
> > > I think if we want to add something to the safety comment, it should be somthing
> > > along the line of "the type of `parent` implies that for the duration of this
> > > call `parent` is a valid device with a non-zero reference count".
> > 
> > I don't understand the need for any safety comment about the parent
> > here.  Again, as long as it is valid when the call is made, that is all
> > that is needed.
> 
> Right, and we could mention that in the safety comment that something of the
> type `&device::Device` is indeed valid by definition and hence fullfills the
> requirement of faux_device_create() to get a valid pointer (or NULL).

Agreed.  I'll go apply patch 1 of the series now and wait for a new
version of 2/2.

thanks!

greg k-h