linux-kernel - Re: [PATCH v4 01/10] dt-bindings: PCI: Add binding for Toshiba TC956x PCIe switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c8642e3-d821-4d71-9808-99fde3db92e8@kernel.org>
Date: Thu, 27 Feb 2025 12:40:21 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 chaitanya chundru <quic_krichai@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, cros-qcom-dts-watchers@...omium.org,
 Jingoo Han <jingoohan1@...il.com>, Bartosz Golaszewski <brgl@...ev.pl>,
 quic_vbadigan@...cnic.com, amitk@...nel.org, dmitry.baryshkov@...aro.org,
 linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 jorge.ramirez@....qualcomm.com
Subject: Re: [PATCH v4 01/10] dt-bindings: PCI: Add binding for Toshiba TC956x
 PCIe switch

On 27/02/2025 04:53, Krishna Chaitanya Chundru wrote:
>>> +
>>> +patternProperties:
>>> +  "^pcie@[1-3],0$":
>>> +    description:
>>> +      child nodes describing the internal downstream ports
>>> +      the tc956x switch.
>>> +    type: object
>>> +    $ref: "#/$defs/tc956x-node"
>>> +    unevaluatedProperties: false
>>> +
>>> +$defs:
>>> +  tc956x-node:
>>> +    type: object
>>> +
>>> +    properties:
>>> +      tc956x,tx-amplitude-microvolt:
>>
>> You already got comments on this.
>>
> In V3 I got a comment saying "-microvolt does not work for you?"
> so based on this we changed to microvolt.


And then what pops up when you test? Drop ref which is pointed out by
testing, example-schema and all other bindings.

Best regards,
Krzysztof