linux-kernel - Re: [PATCH V2 01/12] x86/virt/tdx: Make tdh_vp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1cc904fd-db40-424a-8b40-44f086a6804b@intel.com>
Date: Thu, 27 Feb 2025 16:13:56 +0200
From: Adrian Hunter <adrian.hunter@...el.com>
To: Paolo Bonzini <pbonzini@...hat.com>, <seanjc@...gle.com>
CC: <kvm@...r.kernel.org>, <rick.p.edgecombe@...el.com>,
	<kai.huang@...el.com>, <reinette.chatre@...el.com>, <xiaoyao.li@...el.com>,
	<tony.lindgren@...ux.intel.com>, <binbin.wu@...ux.intel.com>,
	<dmatlack@...gle.com>, <isaku.yamahata@...el.com>, <nik.borisov@...e.com>,
	<linux-kernel@...r.kernel.org>, <yan.y.zhao@...el.com>, <chao.gao@...el.com>,
	<weijiang.yang@...el.com>, <dave.hansen@...ux.intel.com>, <x86@...nel.org>
Subject: Re: [PATCH V2 01/12] x86/virt/tdx: Make tdh_vp_enter() noinstr

On 16/02/25 20:26, Paolo Bonzini wrote:
> On 1/29/25 10:58, Adrian Hunter wrote:
>> Make tdh_vp_enter() noinstr because KVM requires VM entry to be noinstr
>> for 2 reasons:
>>   1. The use of context tracking via guest_state_enter_irqoff() and
>>      guest_state_exit_irqoff()
>>   2. The need to avoid IRET between VM-exit and NMI handling in order to
>>      avoid prematurely releasing NMI inhibit.
>>
>> Consequently make __seamcall_saved_ret() noinstr also. Currently
>> tdh_vp_enter() is the only caller of __seamcall_saved_ret().
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> 
> This can be squashed into "x86/virt/tdx: Add SEAMCALL wrapper to enter/exit TDX guest"; I did that in kvm-coco-queue.

We have re-based on kvm-coco-queue so we in-sync on this.