linux-kernel - Re: [PATCH v2 05/15] gpiolib: introduce gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=McnzfHHLUyYczaza1ao-9iPMoQNOmV3Bm2DSMULCmYBTA@mail.gmail.com>
Date: Thu, 27 Feb 2025 15:10:35 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Marek Szyprowski <m.szyprowski@...sung.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, Michael Walle <mwalle@...nel.org>, 
	Bamvor Jian Zhang <bamv2005@...il.com>, Geert Uytterhoeven <geert+renesas@...der.be>, Keerthy <j-keerthy@...com>, 
	Uwe Kleine-König <ukleinek@...nel.org>, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-pwm@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 05/15] gpiolib: introduce gpio_chip setters that return values

On Thu, Feb 27, 2025 at 3:00 PM Marek Szyprowski
<m.szyprowski@...sung.com> wrote:
>
> On 20.02.2025 10:57, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > Add new variants of the set() and set_multiple() callbacks that have
> > integer return values allowing to indicate failures to users of the GPIO
> > consumer API. Until we convert all GPIO providers treewide to using
> > them, they will live in parallel to the existing ones.
> >
> > Make sure that providers cannot define both. Prefer the new ones and
> > only use the old ones as fallback.
> >
> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > ---
> >       lockdep_assert_held(&gc->gpiodev->srcu);
> >
> > -     if (WARN_ON(unlikely(!gc->set_multiple && !gc->set)))
> > +     if (WARN_ON(unlikely(!gc->set_multiple && !gc->set_multiple_rv)))
> >               return -EOPNOTSUPP;
>
> The above change issues a warning on gpio controllers that doesn't
> support set_multiple() callbacks at all. I think that this wasn't intended.
>

Eek, not at all, thanks for the report, I'll fix it.

Bartosz