linux-kernel - Re: [PATCH] xen/pciback: Make missing GSI non-fatal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e2e48b5-27b6-45a5-975a-7616f2c0f2f5@amd.com>
Date: Thu, 27 Feb 2025 09:57:45 -0500
From: Jason Andryuk <jason.andryuk@....com>
To: "Chen, Jiqian" <Jiqian.Chen@....com>
CC: "stable@...r.kernel.org" <stable@...r.kernel.org>,
	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Juergen Gross
	<jgross@...e.com>, Stefano Stabellini <sstabellini@...nel.org>, "Oleksandr
 Tyshchenko" <oleksandr_tyshchenko@...m.com>, "Huang, Ray" <Ray.Huang@....com>
Subject: Re: [PATCH] xen/pciback: Make missing GSI non-fatal

On 2025-02-26 22:36, Chen, Jiqian wrote:
> On 2025/2/27 04:01, Jason Andryuk wrote:
>> @@ -475,14 +478,14 @@ static int pcistub_init_device(struct pcistub_device *psdev)
>>   #ifdef CONFIG_XEN_ACPI
>>   	if (xen_initial_domain() && xen_pvh_domain()) {
>>   		err = xen_acpi_get_gsi_info(dev, &gsi, &trigger, &polarity);
>> -		if (err) {
>> -			dev_err(&dev->dev, "Fail to get gsi info!\n");
>> -			goto config_release;
>> +		if (err && err != -ENOENT) {
>> +			dev_err(&dev->dev, "Failed to get gsi info! %d\n", err);
> I think here needs " goto config_release;" since it is not ENOENT error.

Yes, thank you for catching that.

Regards,
Jason